Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce scim2/v2/Roles endpoint #486

Merged
merged 22 commits into from
Oct 22, 2023
Merged

Introduce scim2/v2/Roles endpoint #486

merged 22 commits into from
Oct 22, 2023

Conversation

AnuradhaSK
Copy link
Contributor

@AnuradhaSK AnuradhaSK commented Sep 14, 2023 •
edited
Loading

@AnuradhaSK AnuradhaSK mentioned this pull request Oct 15, 2023
Closed
@AnuradhaSK AnuradhaSK marked this pull request as ready for review October 21, 2023 04:13
@AnuradhaSK
add separate v2 service for Roles
20a1a0e
@AnuradhaSK
update the v2/Roles endpoints
befa961
@AnuradhaSK
update role creation in v2/Roles
a41f2a0
@AnuradhaSK
update role manager for listing and updating
79861a9
@AnuradhaSK
improve role management operations
064fe2f
@AnuradhaSK
fix formatting
436aabb
@AnuradhaSK
restrict role creation, deletion, name and permission update in suborgs
b1b5834
@AnuradhaSK
fix filtering issue
1ced1b2
@AnuradhaSK
remove completed todos
3361ea0
@AnuradhaSK
allow role modification in super tenant
6bb9402
@AnuradhaSK
handle bad request
4fbae46
@AnuradhaSK
fix returning empty associated app list
1f5676f
@AnuradhaSK
add audience data of roles to user's and group's assigned role attribute
3237b12
@AnuradhaSK
update license year range in edited files
43a65ef
@AnuradhaSK
update license year range in missed edited files
a5899a6
@AnuradhaSK
use new util method to check whether the tenant is an org
7f720cd
@AnuradhaSK
use role basic info to resolve audience
6a370fb
@AnuradhaSK
add reference to permission and associated app objects
7928bd0
@AnuradhaSK
fix test failures
1927d1c
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6603702783

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6603702925

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6603702783
Status: failure

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6603702925
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6603936743

@AnuradhaSK AnuradhaSK requested a review from thanujalk October 22, 2023 12:56
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6603936743
Status: failure

thanujalk
thanujalk reviewed Oct 22, 2023
View reviewed changes
...scim2.common/src/main/java/org/wso2/carbon/identity/scim2/common/impl/SCIMRoleManagerV2.java Outdated
String attributeValue = node.getValue();
if (LOG.isDebugEnabled()) {
LOG.debug(
"Filtering roles with filter: " + attributeName + " + " + filterOperation + " + " + attributeValue);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we have + as a string here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in 9bb786c

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/6604571178

thanujalk
thanujalk previously approved these changes Oct 22, 2023
View reviewed changes
@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/6604571178
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 22, 2023
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/6604571178

@AnuradhaSK AnuradhaSK merged commit b40d776 into wso2-extensions:master Oct 22, 2023
2 checks passed
@AnuradhaSK AnuradhaSK deleted the roles-v2 branch October 22, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@thanujalk thanujalk thanujalk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AnuradhaSK @jenkins-is-staging @thanujalk