Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shared role creation in sub organization level #399

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Oct 14, 2024

Purpose

When there is a role already available in the sub organization level, then a new role will be created in the sub organization level by appending the _shared_to_ + sharedSubOrgTenantDomain to the role name.

Goals

Resolve the conflict when the roles are shared to the sub organizations when the a role is available with the same name in the sub organization level.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 27.62%. Comparing base (8c75c3d) to head (f10580d).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
...ation/management/handler/SharedRoleMgtHandler.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #399      +/-   ##
============================================
- Coverage     27.64%   27.62%   -0.03%     
  Complexity      368      368              
============================================
  Files            50       50              
  Lines          4145     4149       +4     
  Branches        478      479       +1     
============================================
  Hits           1146     1146              
- Misses         2911     2915       +4     
  Partials         88       88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ShanChathusanda93 ShanChathusanda93 force-pushed the org-path-shared-role-impr-branch branch from dcacdfc to f10580d Compare October 25, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant