Allow application creation in sub organization level #409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShanChathusanda93
force-pushed
the
org-level-app-creation-branch
branch
2 times, most recently
from
8661c32 to
89b3205
Compare
pom.xml
Outdated
| <carbon.kernel.version>4.9.17</carbon.kernel.version> | ||
| <carbon.kernel.package.import.version.range>[4.7.0, 5.0.0)</carbon.kernel.package.import.version.range> | ||
| <carbon.kernel.feature.version>4.6.0</carbon.kernel.feature.version> | ||
| <carbon.kernel.version>4.10.24</carbon.kernel.version> |
There was a problem hiding this comment.
This version needs to be updated once a new kernel release is done with the changes wso2/carbon-kernel#4104
There was a problem hiding this comment.
Updated to the latest kernel release 4.10.26[1]
ShanChathusanda93
force-pushed
the
org-level-app-creation-branch
branch
2 times, most recently
from
c16a54c to
851a98f
Compare
AnuradhaSK
reviewed
Dec 3, 2024
Comment on lines
134
to
135
| if (StringUtils.isEmpty(PrivilegedCarbonContext.getThreadLocalCarbonContext() | ||
| .getApplicationResidentOrganizationId())) { |
There was a problem hiding this comment.
Suggested change
| if (StringUtils.isEmpty(PrivilegedCarbonContext.getThreadLocalCarbonContext() | |
| .getApplicationResidentOrganizationId())) { | |
| if (StringUtils.isNotEmpty(PrivilegedCarbonContext.getThreadLocalCarbonContext() | |
| .getApplicationResidentOrganizationId())) { | |
| true; | |
| } | |
| // eralier logic |
There was a problem hiding this comment.
Ultimately, after enabling app creation within sub org through application mgt API as well, the only thing we need to restrict is inability to create shared/ framgent apps apart from the internal process
There was a problem hiding this comment.
Updated the logic
ShanChathusanda93
force-pushed
the
org-level-app-creation-branch
branch
from
851a98f to
df970df
Compare
ShanChathusanda93
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose