Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sub org level application deletion when the application is a sub org app #411

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShanChathusanda93
Copy link
Contributor

@ShanChathusanda93 ShanChathusanda93 commented Nov 1, 2024

Purpose

Before Merge

  • Please ensure that the PR [1] is merged before merging this PR since the kernel version bump is added to [1] which also needed for this PR as well.

[1] #409

pom.xml Outdated Show resolved Hide resolved
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-role-creation-branch branch 2 times, most recently from 466935c to f83b1d5 Compare December 3, 2024 04:07
@ShanChathusanda93 ShanChathusanda93 changed the title Improve sub org application deletion when accessing through tenant perspective Allow sub org application deletion when accessing through tenant perspective in DCR endpoint Dec 3, 2024
@ShanChathusanda93 ShanChathusanda93 force-pushed the org-level-role-creation-branch branch from f83b1d5 to 0bbcd77 Compare December 3, 2024 17:20
@ShanChathusanda93 ShanChathusanda93 changed the title Allow sub org application deletion when accessing through tenant perspective in DCR endpoint Allow sub org level application deletion when the application is a sub org app Dec 3, 2024
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 47.09%. Comparing base (3833c81) to head (0bbcd77).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
...gement/handler/listener/SharedRoleMgtListener.java 0.00% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #411      +/-   ##
============================================
- Coverage     47.41%   47.09%   -0.32%     
- Complexity     1037     1050      +13     
============================================
  Files           113      113              
  Lines          6766     6911     +145     
  Branches        810      835      +25     
============================================
+ Hits           3208     3255      +47     
- Misses         3269     3368      +99     
+ Partials        289      288       -1     
Flag Coverage Δ
unit 31.01% <0.00%> (+1.90%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants