From 0f5fab15fdd83ad183992c60af54739e3c904f50 Mon Sep 17 00:00:00 2001 From: rusirijayodaillesinghe Date: Wed, 4 Sep 2024 13:31:36 +0530 Subject: [PATCH] Fix empty resource paths not caught by the existing validation logic implementation Fixes https://github.com/wso2/api-manager/issues/3093 --- .../org/wso2/carbon/apimgt/impl/definitions/OAS2Parser.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/definitions/OAS2Parser.java b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/definitions/OAS2Parser.java index af0db54abfdf..81a25bd6685f 100644 --- a/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/definitions/OAS2Parser.java +++ b/components/apimgt/org.wso2.carbon.apimgt.impl/src/main/java/org/wso2/carbon/apimgt/impl/definitions/OAS2Parser.java @@ -685,8 +685,10 @@ public APIDefinitionValidationResponse validateAPIDefinition(String apiDefinitio // Which is a known issue of Swagger 2.0 parser Set uriTemplates = null; uriTemplates = getURITemplates(apiDefinition); - if (uriTemplates == null) { + if (uriTemplates.size() == 0) { validationResponse.setValid(false); + OASParserUtil.addErrorToValidationResponse(validationResponse, + "Empty resource paths found in the swagger definition"); return validationResponse; } else { for (URITemplate uriTemplate : uriTemplates) {