-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SMS based password recovery support #6418
Merged
RushanNanayakkara
merged 29 commits into
wso2:master
from
RushanNanayakkara:sms_otp_pw_recovery_2
Jun 26, 2024
Merged
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
5eef44c
Revert "Revert "Update recovery portal to support SMS OTP based passw…
RushanNanayakkara 9b87c22
Revert "revertinng 5808"
RushanNanayakkara b900af4
Add sms recovery to Account recovery section
RushanNanayakkara 271435b
Add sms recovery in myaccount
RushanNanayakkara 6167995
Add choose other option button to sms otp page
RushanNanayakkara f884dc5
Add otp resend success message
RushanNanayakkara 5d09f52
bug fixes
RushanNanayakkara 533f221
rename beta tag config
RushanNanayakkara 79dd320
bug fixes
RushanNanayakkara 92391d2
Addressing review comments
RushanNanayakkara e222834
remove unnecessary encoding
RushanNanayakkara 3d893f2
Add change set
RushanNanayakkara 0dd77c8
Addressing comments
RushanNanayakkara 460602d
remove account-recovery connector from auto enable list
RushanNanayakkara 7cb4d54
Addressing review comments
RushanNanayakkara 1e19da2
Add unit tests
RushanNanayakkara c7cf2af
Addressing review comments
RushanNanayakkara a62056b
Keep only unit tests for testing
RushanNanayakkara 545a5d5
undo temp PR builder changes
RushanNanayakkara 4c2a8f9
Add component id to error message tip
RushanNanayakkara 8f2a798
Add unit tests
RushanNanayakkara 9029033
Addressing comments
RushanNanayakkara f078ab4
Addressing comments
RushanNanayakkara cc994db
Fix style issues
RushanNanayakkara 65768c4
Add missing i18n Strings
RushanNanayakkara 0382f56
add sms-otp to branding preference screens
RushanNanayakkara eb41f6f
revert pnpm-lock.yaml and package.json changes
RushanNanayakkara 34b1b04
addressing comments
RushanNanayakkara 1e59bc5
Addressing comments
RushanNanayakkara File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
--- | ||
"@wso2is/identity-apps-core": minor | ||
"@wso2is/console": minor | ||
"@wso2is/admin.server-configurations.v1": patch | ||
"@wso2is/admin.branding.v1": patch | ||
"@wso2is/admin.core.v1": patch | ||
"@wso2is/myaccount": patch | ||
"@wso2is/i18n": patch | ||
--- | ||
|
||
Introduce sms otp for password recovery |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
apps/myaccount/src/components/account-recovery/options/sms-recovery/sms-recovery.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
/** | ||
* Copyright (c) 2024, WSO2 LLC. (https://www.wso2.com). | ||
* | ||
* WSO2 LLC. licenses this file to you under the Apache License, | ||
* Version 2.0 (the "License"); you may not use this file except | ||
* in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, | ||
* software distributed under the License is distributed on an | ||
* "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
* KIND, either express or implied. See the License for the | ||
* specific language governing permissions and limitations | ||
* under the License. | ||
*/ | ||
|
||
.mobile-field { | ||
width: 200px !important; | ||
} | ||
|
||
.small-description{ | ||
margin-top: 10px !important; | ||
font-size: 12px; | ||
} | ||
|
||
.description { | ||
margin-top: 7px; | ||
} | ||
|
||
.inline.fields { | ||
margin-top: 8px; | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are moving away from index files right ?
Then shall we let this new "sms-recovery" file to be directly imported instead of using index file ?
cc: @JayaShakthi97
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this index file is already here, wouldn't it make sense to use it instead of using direct imports for this file only?