From 074ba5627847815fbfb00d1dc7b8b328c16fbd86 Mon Sep 17 00:00:00 2001
From: Pavindu Lakshan <pavindulakshan@gmail.com>
Date: Tue, 11 Jun 2024 14:58:29 +0530
Subject: [PATCH 1/3] Improve readability in legacy auth flow builder rendering
 logic

---
 .../components/sign-on-methods-core.tsx       | 102 +++++++++---------
 1 file changed, 54 insertions(+), 48 deletions(-)

diff --git a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
index be81eaaf553..1a6b423d466 100644
--- a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
+++ b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
@@ -899,6 +899,59 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
         );
     };
 
+    const renderLegacyAuthenticationFlowBuilder = (): ReactElement => {
+        if (isLoading || isAuthenticatorsFetchRequestLoading) {
+            return (
+                <ContentLoader inline="centered" active />
+            );
+        }
+
+        const isDefaultAuthFlow: boolean = isDefaultFlowConfiguration();
+
+        return (
+            !readOnly && !loginFlow && isDefaultAuthFlow ? (
+                <SignInMethodLanding
+                    readOnly={ readOnly }
+                    clientId={ clientId }
+                    onLoginFlowSelect={ (type: LoginFlowTypes) => {
+                        handleLoginFlowSelect(
+                            type,
+                            googleAuthenticators,
+                            gitHubAuthenticators,
+                            facebookAuthenticators,
+                            microsoftAuthenticators,
+                            appleAuthenticators
+                        );
+                    } }
+                    data-componentid={ `${componentId}-landing` }
+                />
+            ) : (
+                <SignInMethodCustomization
+                    appId={ appId }
+                    applicationName={ application?.name }
+                    isApplicationShared={ isApplicationShared }
+                    authenticators={ authenticators }
+                    clientId={ clientId }
+                    authenticationSequence={ moderatedAuthenticationSequence }
+                    onIDPCreateWizardTrigger={ (type: string, cb: () => void, template: any) => {
+                        setSelectedIDPTemplate(template);
+                        setIDPCreateWizardTriggerOrigin("EXTERNAL");
+                        setIDPTemplateTypeToTrigger(type);
+                        setShowMissingSocialAuthenticatorModal(false);
+                        setShowIDPCreateWizard(true);
+                        broadcastIDPCreateSuccessMessage = cb;
+                    } }
+                    onUpdate={ onUpdate }
+                    onReset={ handleLoginFlowReset }
+                    data-componentid={ componentId }
+                    isLoading={ isAuthenticatorsFetchRequestLoading }
+                    setIsLoading={ setIsAuthenticatorsFetchRequestLoading }
+                    readOnly={ readOnly }
+                />
+            )
+        );
+    };
+
     return (
         <AuthenticationFlowProvider
             application={ cloneDeep(application) }
@@ -912,54 +965,7 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
             authenticationSequence={ moderatedAuthenticationSequence }
         >
             <AuthenticationFlowBuilder
-                legacyBuilder={ (
-                    <>
-                        { !(isLoading || isAuthenticatorsFetchRequestLoading) ? (
-                            !readOnly && !loginFlow && isDefaultFlowConfiguration() ? (
-                                <SignInMethodLanding
-                                    readOnly={ readOnly }
-                                    clientId={ clientId }
-                                    onLoginFlowSelect={ (type: LoginFlowTypes) => {
-                                        handleLoginFlowSelect(
-                                            type,
-                                            googleAuthenticators,
-                                            gitHubAuthenticators,
-                                            facebookAuthenticators,
-                                            microsoftAuthenticators,
-                                            appleAuthenticators
-                                        );
-                                    } }
-                                    data-componentid={ `${componentId}-landing` }
-                                />
-                            ) : (
-                                <SignInMethodCustomization
-                                    appId={ appId }
-                                    applicationName={ application?.name }
-                                    isApplicationShared={ isApplicationShared }
-                                    authenticators={ authenticators }
-                                    clientId={ clientId }
-                                    authenticationSequence={ moderatedAuthenticationSequence }
-                                    onIDPCreateWizardTrigger={ (type: string, cb: () => void, template: any) => {
-                                        setSelectedIDPTemplate(template);
-                                        setIDPCreateWizardTriggerOrigin("EXTERNAL");
-                                        setIDPTemplateTypeToTrigger(type);
-                                        setShowMissingSocialAuthenticatorModal(false);
-                                        setShowIDPCreateWizard(true);
-                                        broadcastIDPCreateSuccessMessage = cb;
-                                    } }
-                                    onUpdate={ onUpdate }
-                                    onReset={ handleLoginFlowReset }
-                                    data-componentid={ componentId }
-                                    isLoading={ isAuthenticatorsFetchRequestLoading }
-                                    setIsLoading={ setIsAuthenticatorsFetchRequestLoading }
-                                    readOnly={ readOnly }
-                                />
-                            )
-                        ) : (
-                            <ContentLoader inline="centered" active />
-                        ) }
-                    </>
-                ) }
+                legacyBuilder={ renderLegacyAuthenticationFlowBuilder() }
                 onIDPCreateWizardTrigger={ (type: string, cb: () => void, template: any) => {
                     setSelectedIDPTemplate(template);
                     setIDPCreateWizardTriggerOrigin("EXTERNAL");

From 77b558cc76614bbf7abaff167a05e8ca76792cae Mon Sep 17 00:00:00 2001
From: Pavindu Lakshan <pavindulakshan@gmail.com>
Date: Tue, 11 Jun 2024 16:01:27 +0530
Subject: [PATCH 2/3] Address review comments

---
 .../components/sign-on-methods-core.tsx            | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
index 1a6b423d466..ead8bef6ff7 100644
--- a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
+++ b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
@@ -906,10 +906,8 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
             );
         }
 
-        const isDefaultAuthFlow: boolean = isDefaultFlowConfiguration();
-
-        return (
-            !readOnly && !loginFlow && isDefaultAuthFlow ? (
+        if (!readOnly && !loginFlow && isDefaultFlowConfiguration()) {
+            return (
                 <SignInMethodLanding
                     readOnly={ readOnly }
                     clientId={ clientId }
@@ -925,7 +923,9 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
                     } }
                     data-componentid={ `${componentId}-landing` }
                 />
-            ) : (
+            );
+        } else {
+            return (
                 <SignInMethodCustomization
                     appId={ appId }
                     applicationName={ application?.name }
@@ -948,8 +948,8 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
                     setIsLoading={ setIsAuthenticatorsFetchRequestLoading }
                     readOnly={ readOnly }
                 />
-            )
-        );
+            );
+        }
     };
 
     return (

From 3f3ba24b12beda051ec8e5369a1bafc1af4faaf1 Mon Sep 17 00:00:00 2001
From: Pavindu Lakshan <pavindulakshan@gmail.com>
Date: Tue, 11 Jun 2024 16:03:31 +0530
Subject: [PATCH 3/3] Remove unnecessary else clause

---
 .../components/sign-on-methods-core.tsx       | 50 +++++++++----------
 1 file changed, 25 insertions(+), 25 deletions(-)

diff --git a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
index ead8bef6ff7..acc0083cb6a 100644
--- a/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
+++ b/features/admin.applications.v1/components/settings/sign-on-methods/components/sign-on-methods-core.tsx
@@ -924,32 +924,32 @@ export const SignOnMethodsCore: FunctionComponent<SignOnMethodsCorePropsInterfac
                     data-componentid={ `${componentId}-landing` }
                 />
             );
-        } else {
-            return (
-                <SignInMethodCustomization
-                    appId={ appId }
-                    applicationName={ application?.name }
-                    isApplicationShared={ isApplicationShared }
-                    authenticators={ authenticators }
-                    clientId={ clientId }
-                    authenticationSequence={ moderatedAuthenticationSequence }
-                    onIDPCreateWizardTrigger={ (type: string, cb: () => void, template: any) => {
-                        setSelectedIDPTemplate(template);
-                        setIDPCreateWizardTriggerOrigin("EXTERNAL");
-                        setIDPTemplateTypeToTrigger(type);
-                        setShowMissingSocialAuthenticatorModal(false);
-                        setShowIDPCreateWizard(true);
-                        broadcastIDPCreateSuccessMessage = cb;
-                    } }
-                    onUpdate={ onUpdate }
-                    onReset={ handleLoginFlowReset }
-                    data-componentid={ componentId }
-                    isLoading={ isAuthenticatorsFetchRequestLoading }
-                    setIsLoading={ setIsAuthenticatorsFetchRequestLoading }
-                    readOnly={ readOnly }
-                />
-            );
         }
+
+        return (
+            <SignInMethodCustomization
+                appId={ appId }
+                applicationName={ application?.name }
+                isApplicationShared={ isApplicationShared }
+                authenticators={ authenticators }
+                clientId={ clientId }
+                authenticationSequence={ moderatedAuthenticationSequence }
+                onIDPCreateWizardTrigger={ (type: string, cb: () => void, template: any) => {
+                    setSelectedIDPTemplate(template);
+                    setIDPCreateWizardTriggerOrigin("EXTERNAL");
+                    setIDPTemplateTypeToTrigger(type);
+                    setShowMissingSocialAuthenticatorModal(false);
+                    setShowIDPCreateWizard(true);
+                    broadcastIDPCreateSuccessMessage = cb;
+                } }
+                onUpdate={ onUpdate }
+                onReset={ handleLoginFlowReset }
+                data-componentid={ componentId }
+                isLoading={ isAuthenticatorsFetchRequestLoading }
+                setIsLoading={ setIsAuthenticatorsFetchRequestLoading }
+                readOnly={ readOnly }
+            />
+        );
     };
 
     return (