-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the password length validation with Password max allowed length config. #7185
base: master
Are you sure you want to change the base?
Changes from 9 commits
1f4d992
a0c0069
0057877
e177cdc
56e4045
2186b24
6d22cd6
6d4941b
18aa02b
74c5553
3f33e36
00a3218
7d7b365
95586aa
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
"@wso2is/admin.validation.v1": minor | ||
"@wso2is/admin.core.v1": minor | ||
"@wso2is/myaccount": minor | ||
"@wso2is/console": minor | ||
"@wso2is/core": minor | ||
"@wso2is/i18n": minor | ||
--- | ||
|
||
Add the passwordMaxAllowed length config for password length values validation. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
/** | ||
* Copyright (c) 2022, WSO2 LLC. (https://www.wso2.com). | ||
* Copyright (c) 2022-2024, WSO2 LLC. (https://www.wso2.com). | ||
* | ||
* WSO2 LLC. licenses this file to you under the Apache License, | ||
* Version 2.0 (the "License"); you may not use this file except | ||
|
@@ -163,6 +163,7 @@ export class Config { | |
window["AppUtils"]?.getConfig()?.ui?.isMultipleEmailsAndMobileNumbersEnabled, | ||
isPasswordInputValidationEnabled: window["AppUtils"]?.getConfig()?.ui?.isPasswordInputValidationEnabled, | ||
isProfileUsernameReadonly: window["AppUtils"]?.getConfig()?.ui?.isProfileUsernameReadonly, | ||
passwordPolicyConfigs: window[ "AppUtils" ]?.getConfig()?.ui?.passwordPolicyConfigs, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We don't use this value anywhere in myaccount, do we? if it's not used, better not to add it here. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed by 74c5553 |
||
privacyPolicyConfigs: window["AppUtils"]?.getConfig()?.ui?.privacyPolicyConfigs, | ||
productName: window["AppUtils"]?.getConfig()?.ui?.productName, | ||
productVersionConfig: window["AppUtils"]?.getConfig()?.ui?.productVersionConfig, | ||
|
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the changes to core and i18n are minor, let's add a separate changeset for those modules with
patch
version upgrade.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed by 3f33e36