From 01086c2e6beabd67d35c88b91470c2959e1e8447 Mon Sep 17 00:00:00 2001
From: Rusiri illesinghe <48326709+RusJaI@users.noreply.github.com>
Date: Fri, 16 Feb 2024 14:18:28 +0530
Subject: [PATCH] Sync jsp changes from identity apps (#13376)

* Changes from identity-apps

* Remove backup code usage

* update the min css file name

* upgrade identity-apps version

* Add changes from https://github.com/wso2/identity-apps/pull/3692

* Add fixes from PR : https://github.com/wso2-support/identity-apps/pull/347
U2 number : 7772

* Revert "Add fixes from PR : https://github.com/wso2-support/identity-apps/pull/347"

This reverts commit 19833fe28e8e219b7a2ae26c5c8a40bf2d088f59.
---
 .../product/src/main/extensions/basicauth.jsp             | 3 ++-
 .../distribution/product/src/main/extensions/login.jsp    | 8 ++++----
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/modules/distribution/product/src/main/extensions/basicauth.jsp b/modules/distribution/product/src/main/extensions/basicauth.jsp
index 66b3647813..3677d95b3d 100644
--- a/modules/distribution/product/src/main/extensions/basicauth.jsp
+++ b/modules/distribution/product/src/main/extensions/basicauth.jsp
@@ -277,6 +277,7 @@
                     name="password"
                     value=""
                     autocomplete="off"
+                    required
                     tabindex="2"
                     placeholder="<%=AuthenticationEndpointUtil.i18n(resourceBundle, "password")%>"
                     data-testid="login-page-password-input"
@@ -403,7 +404,7 @@
                 name="chkRemember"
                 data-testid="login-page-remember-me-checkbox"
             >
-            <label><%=AuthenticationEndpointUtil.i18n(resourceBundle, "remember.me")%></label>
+            <label for="chkRemember"><%=AuthenticationEndpointUtil.i18n(resourceBundle, "remember.me")%></label>
         </div>
     </div>
     <input type="hidden" name="sessionDataKey" value='<%=Encode.forHtmlAttribute
diff --git a/modules/distribution/product/src/main/extensions/login.jsp b/modules/distribution/product/src/main/extensions/login.jsp
index 9248783f0d..af318156f8 100644
--- a/modules/distribution/product/src/main/extensions/login.jsp
+++ b/modules/distribution/product/src/main/extensions/login.jsp
@@ -364,14 +364,14 @@
                                     <div class="external-login blurring external-login-dimmer">
                                         <div class="field">
                                             <button
-                                                class="ui button fluid"
+                                                class="ui button secondary fluid"
                                                 onclick="handleNoDomain(this,
                                                     '<%=Encode.forJavaScriptAttribute(Encode.forUriComponent(idpName))%>',
                                                     '<%=Encode.forJavaScriptAttribute(Encode.forUriComponent(idpEntry.getValue()))%>')"
                                                 id="icon-<%=iconId%>"
                                                 title="<%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with")%> <%=Encode.forHtmlAttribute(idpName)%>"
                                             >
-                                                <img class="ui image" src="<%=Encode.forHtmlAttribute(imageURL)%>">
+                                                <img role="presentation" class="ui image" src="<%=Encode.forHtmlAttribute(imageURL)%>">
                                                 <span><%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with")%> <%=Encode.forHtmlContent(idpName)%></span>
                                             </button>
                                         </div>
@@ -419,7 +419,7 @@
                                     title="<%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with")%>
                                     <%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with" )%>">
                                     <i class="usb icon"></i>
-                                    <img src="libs/themes/default/assets/images/icons/fingerprint.svg" alt="Fido Logo" />
+                                    <img role="presentation" src="libs/themes/default/assets/images/icons/fingerprint.svg" alt="Fido Logo" />
                                     <span>
                                         <%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with" )%>
                                         <%=AuthenticationEndpointUtil.i18n(resourceBundle, "fido.authenticator" )%>
@@ -438,7 +438,7 @@
                                         title="<%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with")%>
                                             <%=AuthenticationEndpointUtil.i18n(resourceBundle, "magic.link" )%>"
                                         data-componentid="login-page-sign-in-with-magic-link">
-                                        <img class="ui image" src="libs/themes/default/assets/images/icons/magic-link-icon.svg" alt="Magic Link Logo" />
+                                        <img role="presentation" class="ui image" src="libs/themes/default/assets/images/icons/magic-link-icon.svg" alt="Magic Link Logo" />
                                         <span>
                                             <%=AuthenticationEndpointUtil.i18n(resourceBundle, "sign.in.with" )%>
                                             <%=AuthenticationEndpointUtil.i18n(resourceBundle, "magic.link" )%>