Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can not login in to the console when configure email as the username format #16930

Closed
asekawa opened this issue Oct 12, 2023 · 2 comments
Closed

Comments

@asekawa
Copy link

asekawa commented Oct 12, 2023

Describe the issue:

Can not login in to the console when configure email as the username format , even if we use correct credentials

Screenshot 2023-10-12 at 11 56 33

Git issue : #16323
Local pack used : https://drive.google.com/drive/u/2/folders/1UubS6-c-_-3lnp2TelO6yoYSBX5IcXkZ
Reference documentation and use case : https://docs.google.com/document/d/1aaCJ70OjAxICRMk72ctYDsG6khIfxojzu8OG0pBJGnY/edit

How to reproduce:

1.Go to the console
2.Go to account login =>Go to username-validation and set email as the username type.
3.Logout from the console and try to login again
Expected behavior:

Environment information (Please complete the following information; remove any unnecessary fields) :

  • Product Version: [e.g., IS 5.10.0, IS 5.9.0]
  • OS: [e.g., Windows, Linux, Mac]
  • Database: [e.g., MySQL, H2]
  • Userstore: [e.g., LDAP, JDBC]

Optional Fields

Related issues:

Suggested labels:

@Thumimku
Copy link
Contributor

Thumimku commented Oct 13, 2023

Difference between previous email type user name config and current config is

Previous config ensures 2 things

  • New user creation should validate email type username.
  • All users in the tenant are email type.

With current EmailType Username config we can't ensure 2nd option.
(Ex: It's possible that there can be users with usernames : sample and sample@test.com in the test.com tenant.)

To differentiate this, We need to take only one of following decisions,

  • Tenant domain can't be in email domain format.
  • There can't be users with email domain which is same as tenant domain.
  • If there is a requirement that particular tenant need to have a user with similar email domain then the tenant can't have alpha numeric users (we can do this with a config)

Organisation features we are introducing is following first option. Organisation domain can't be email domain.

@bhagyasakalanka
Copy link
Contributor

We disable username validation feature. Now, the username will be validated based on the userstore level regex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

5 participants