Skip to content

Commit

Permalink
update rust action, fix clippy 📎 errors
Browse files Browse the repository at this point in the history
  • Loading branch information
wssheldon committed Sep 29, 2024
1 parent fc82783 commit efdb345
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 29 deletions.
39 changes: 19 additions & 20 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Rust CI
name: Rust

on:
push:
Expand All @@ -20,9 +20,9 @@ jobs:
profile: minimal
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
with:
command: check
- name: Run cargo check
working-directory: ./pond
run: cargo check

test:
name: Test Suite
Expand All @@ -34,9 +34,9 @@ jobs:
profile: minimal
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
with:
command: test
- name: Run cargo test
working-directory: ./pond
run: cargo test

fmt:
name: Rustfmt
Expand All @@ -49,10 +49,9 @@ jobs:
toolchain: stable
override: true
- run: rustup component add rustfmt
- uses: actions-rs/cargo@v1
with:
command: fmt
args: --all -- --check
- name: Run cargo fmt
working-directory: ./pond
run: cargo fmt --all -- --check

clippy:
name: Clippy
Expand All @@ -65,12 +64,10 @@ jobs:
toolchain: stable
override: true
- run: rustup component add clippy
- uses: actions-rs/cargo@v1
with:
command: clippy
args: -- -D warnings
- name: Run cargo clippy
working-directory: ./pond
run: cargo clippy -- -D warnings

# Optional: Add coverage reporting
coverage:
name: Code coverage
runs-on: ubuntu-latest
Expand All @@ -81,15 +78,17 @@ jobs:
profile: minimal
toolchain: stable
override: true
- uses: actions-rs/cargo@v1
with:
command: test
args: --no-fail-fast
- name: Run tests with coverage
working-directory: ./pond
run: |
cargo test --no-fail-fast
env:
CARGO_INCREMENTAL: "0"
RUSTFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests"
RUSTDOCFLAGS: "-Zprofile -Ccodegen-units=1 -Cinline-threshold=0 -Clink-dead-code -Coverflow-checks=off -Cpanic=abort -Zpanic_abort_tests"
- uses: actions-rs/grcov@v0.1
with:
config: ./pond/.github/grcov.yml
- uses: codecov/codecov-action@v3
with:
file: ${{ steps.coverage.outputs.report }}
Expand Down
2 changes: 1 addition & 1 deletion pond/pond-duckling/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ version = "0.1.0"
edition = "2021"

[dependencies]
arrow = { version = "*", features = ["ipc"] }
arrow = { version = "52.0.0", features = ["ipc"] }
duckdb = { version = "^1.0.0", features = ["bundled"] }
lambda_http = { version = "0.13.0", default-features = false, features = [
"apigw_http",
Expand Down
2 changes: 1 addition & 1 deletion pond/pond-planner/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ struct QueryPlanner {
#[derive(Default)]
struct DistributedPlan {
table: String,
group_column: Option<String>,
group_column: String,
agg_function: String,
partitions: Vec<String>,
}
Expand Down
7 changes: 0 additions & 7 deletions pond/rustfmt.toml

This file was deleted.

0 comments on commit efdb345

Please sign in to comment.