Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Performance is just 88% #49

Open
lisn3 opened this issue Mar 20, 2021 · 7 comments
Open

Model Performance is just 88% #49

lisn3 opened this issue Mar 20, 2021 · 7 comments

Comments

@lisn3
Copy link

lisn3 commented Mar 20, 2021

I trained the model using parameters in the paper for 300 epochs, but the final training accuracy is just 88%, and the testing F1-score is 88%. Could you please give some ideas? Has anyone got a higher performance?

@wuyifan18
Copy link
Owner

@lisn3 try to use list to generate the full dataset, just like this:

# If you what to replicate the DeepLog paper results(Actually, I have a better result than DeepLog paper results),
# you should use the 'list' not 'set' to obtain the full dataset, I use 'set' just for test and acceleration.
hdfs = set()
# hdfs = []
with open('data/' + name, 'r') as f:
for ln in f.readlines():
ln = list(map(lambda n: n - 1, map(int, ln.strip().split())))
ln = ln + [-1] * (window_size + 1 - len(ln))
hdfs.add(tuple(ln))
# hdfs.append(tuple(ln))
print('Number of sessions({}): {}'.format(name, len(hdfs)))
return hdfs

@lisn3
Copy link
Author

lisn3 commented Mar 20, 2021

Thanks, I will try again.

@Abraham12580
Copy link

Thanks, I will try again.

hi,have your performance gotten improved yet?

@ldselvera
Copy link

Unfortunately, that will be the highest performance with this implementation. The only way to increase it is by modifying the model and fine tuning parameters.

@hayhan
Copy link

hayhan commented Nov 23, 2021

Use one-hot vector for input data may help.

@gutjuri
Copy link
Contributor

gutjuri commented Feb 26, 2022

If you do what wuifan suggested (replacing set with list) you'll get a tremendously increased performance.

elapsed_time: 2877.333s
false positive (FP): 841, false negative (FN): 381, Precision: 95.138%, Recall: 97.737%, F1-measure: 96.420%

@Abraham12580
Copy link

Abraham12580 commented Feb 26, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants