Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix up CMakeLists.txt #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

SteelT1
Copy link

@SteelT1 SteelT1 commented May 29, 2018

Fixes up CMakeLists.txt so the rest of the files is in the proper sections, honestly not sure if this is right, but it works and builds.

@wyatt8740
Copy link
Owner

Um, looking at the commit, I'm not sure what's different.
A lot of the libs are still basically in a 'miscellaneous' section, and I think I already did the gens/MAME YM2612 thing.

Thanks for the request, though. My car got screwed up by a minivan the other week, and I'm going to get it back from a body shop today, but once that's taken care of I can look at this in more detail.

I'm also new to this whole 'having people make pull requests' thing - usually my projects don't get that much attention!-- So I'm sorry if I'm handling these badly. I'm thankful that someone's helping out. :)

@SteelT1
Copy link
Author

SteelT1 commented May 30, 2018

The gens/MAME YM2612 thing was changed so before it checks if USE_GENS is enabled, it checks if USE_GME_VGM or USE_GME_GYM is enabled. Also put the remaining stuff under if (USE_GME_VGM), not sure if that's correct and nothing will break from doing this, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants