Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhoneGap Build fails with CLI 8.0.0 (Android Platform 7.0.0) #263

Closed
mkihellas opened this issue Feb 28, 2018 · 3 comments
Closed

PhoneGap Build fails with CLI 8.0.0 (Android Platform 7.0.0) #263

mkihellas opened this issue Feb 28, 2018 · 3 comments

Comments

@mkihellas
Copy link

mkihellas commented Feb 28, 2018

Hello there,
We are trying to update our App from Cordova CLI 7.1.0 to 8.0.0 and it seems that cordova-imagePicker plugin causes the build to fail on Android.

Looks like the problem is that you are using the source-file tag for images instead of the resource-file tag on plugin.xml.
example

We checked all our 3rd party plugins and they are handling images using the resource-file tag. For example:
example2

When we remove the cordova-imagePicker plugin, the build succeeds.
More info can be found in this discussion here: https://forums.adobe.com/thread/2445961

Is there any chance to update your plugin and use the resource-file tag for images on plugin.xml, so we will be able to build with CLI 8.0.0?

@mkihellas mkihellas changed the title PhoneGap Build fails with CLI 8.0.0 PhoneGap Build fails with CLI 8.0.0 (Android Platform 7.0.0) Feb 28, 2018
@mkihellas
Copy link
Author

I made it work in my repo: https://github.com/mkihellas/cordova-imagePicker
I changed all the source-file regarding xml and png files to resource-file and PhoneGap builds successfully for Android with CLI 8.0.0

HINT: I had also to do some changes in ImageFetcher.java.
mkihellas/cordova-imagePicker@61c18fc
Check #262 for more info.

@christianidas
Copy link

This should not be closed, right? Shouldn't it remain open until it has been fixed and versioned in the plugin?

@rafaelmb
Copy link

It should. But this repo is 2 years without update. And the issue owner decided to close, no interaction from the developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants