Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking changes not documented #1988

Closed
makkes opened this issue Aug 15, 2024 · 3 comments
Closed

Breaking changes not documented #1988

makkes opened this issue Aug 15, 2024 · 3 comments

Comments

@makkes
Copy link

makkes commented Aug 15, 2024

The Flux project had a hard time today bumping go-gitlab to its latest version because f49ba02 apparently broke the API as the original HTTP error isn't returned anymore.

I would like to start a discussion on documenting such breaking changes somewhere going forward. Many projects do this in the release notes, others in a dedicated CHANGELOG.md file.

@svanharmelen
Copy link
Member

Hi @makkes, I'm sorry this change caused issues for you 😞

I fully understand its not cool to ship breaking changes without people being able to easily see what changed so they can update the relevant bits without having to investigate issues themselves.

So I'm open to start using releases instead of just tags and add some bits to indicate any breaking changes that might be in that release. Hope that will improve things going forward...

@svanharmelen
Copy link
Member

I'm not 100% sure I got all the breaking changes in the v0.108.0 release, but will try to keep track of any breaking changes that are getting merged from now on...

@makkes
Copy link
Author

makkes commented Aug 26, 2024

Thank you so much @svanharmelen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants