fix: 🐛 raf from webpack than from script tag

xcarpentier · Jul 14, 2020 · 5a665b3 · 5a665b3
1 parent e4bf36a
commit 5a665b3
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 7 deletions.
diff --git a/App.tsx b/App.tsx
@@ -20,7 +20,8 @@ const base64 =
   'CjAwMDAwMDAwNzkgMDAwMDAgbiAKMDAwMDAwMDE3MyAwMDAwMCBuIAowMDAwMDAwMzAxIDAw' +
   'MDAwIG4gCjAwMDAwMDAzODAgMDAwMDAgbiAKdHJhaWxlcgo8PAogIC9TaXplIDYKICAvUm9v' +
   'dCAxIDAgUgo+PgpzdGFydHhyZWYKNDkyCiUlRU9G'
-const uri = 'http://gahp.net/wp-content/uploads/2017/09/sample.pdf'
+// const uri = 'http://gahp.net/wp-content/uploads/2017/09/sample.pdf'
+const uri = 'https://www.dropbox.com/s/r7nfdzj6h2kosnh/bhjbjbj.pdf?dl=0&raw=1'
 
 function App() {
   const [error, setError] = React.useState<

diff --git a/react-pdf/index.html b/react-pdf/index.html
@@ -5,7 +5,6 @@
     <meta name="viewport" content="width=device-width, initial-scale=1.0" />
     <script src="//cdn.jsdelivr.net/npm/pdfjs-dist@2.1.266/build/pdf.min.js"></script>
     <script src="//cdn.jsdelivr.net/npm/pdfjs-dist@2.1.266/web/pdf_viewer.min.js"></script>
-    <script src="https://wzrd.in/standalone/raf@latest"></script>
     <script
       crossorigin
       src="https://unpkg.com/react@16/umd/react.production.min.js"

diff --git a/react-pdf/webpack.config.js b/react-pdf/webpack.config.js
@@ -37,7 +37,6 @@ module.exports = {
   externals: {
     react: 'React',
     'react-dom': 'ReactDOM',
-    raf: 'raf',
     'pdfjs-dist': 'pdfjsLib',
     'pdfjs-dist/lib/web/pdf_link_service': 'pdfjsViewer',
   },

diff --git a/src/bundleContainer.ts b/src/bundleContainer.ts
diff --git a/src/index.tsx b/src/index.tsx
@@ -84,7 +84,6 @@ function viewerHtml(
     }, user-scalable=${withPinchZoom ? 'yes' : 'no'}" />
     <script src="https://cdn.jsdelivr.net/npm/pdfjs-dist@2.1.266/build/pdf.min.js"></script>
     <script src="https://cdn.jsdelivr.net/npm/pdfjs-dist@2.1.266/web/pdf_viewer.min.js"></script>
-    <script src="https://wzrd.in/standalone/raf@latest"></script>
     <script
       crossorigin
       src="https://unpkg.com/react@16/umd/react.production.min.js"
@@ -285,7 +284,13 @@ class PdfReader extends React.Component<Props, State> {
 
   init = async () => {
     try {
-      const { source, customStyle, withScroll, withPinchZoom,  } = this.props
+      const {
+        source,
+        customStyle,
+        withScroll,
+        withPinchZoom,
+        maximumPinchZoomScale,
+      } = this.props
       const { renderType } = this.state
       switch (renderType!) {
         case 'URL_TO_BASE64': {
@@ -295,6 +300,7 @@ class PdfReader extends React.Component<Props, State> {
             customStyle,
             withScroll,
             withPinchZoom,
+            maximumPinchZoomScale,
           )
           break
         }
@@ -305,6 +311,7 @@ class PdfReader extends React.Component<Props, State> {
             customStyle,
             withScroll,
             withPinchZoom,
+            maximumPinchZoomScale,
           )
           break
         }