Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple databases #10

Merged
merged 1 commit into from
Nov 22, 2021
Merged

Support multiple databases #10

merged 1 commit into from
Nov 22, 2021

Conversation

copelco
Copy link

@copelco copelco commented Nov 20, 2021

Update django-pgviews to support multiple databases (per #9):

  • Adds multiple database instructions to README.
  • A --database option may now be provided to the management commands to specify a non-default database.
  • By default, django-pgviews continues to use the default database and no changes are required for this use case.
  • Includes multi-database related unit tests in tests/test_project/test_project/multidbtest.

Copy link
Collaborator

@mikicz mikicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty much perfect from what I can see!

I ran the tests locally and it all passed (no idea why CircleCI didn't run tests), I also tried using it in my company's project and it all works great there as well, so merging this and will release it.

@si14
Copy link

si14 commented Dec 6, 2021

Thanks a lot @mikicz and @copelco, this is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants