Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Matrix Inputs #15

Open
xiaodaigh opened this issue Nov 24, 2019 · 2 comments
Open

Support Matrix Inputs #15

xiaodaigh opened this issue Nov 24, 2019 · 2 comments

Comments

@xiaodaigh
Copy link
Owner

No description provided.

@baggepinnen
Copy link

baggepinnen commented Feb 12, 2020

This would be great! I have always found DataFrames to be clunky and pretty much never use them. My inputs are often low-dimensional embeddings without any real names, making putting them in a dataframe just an extra step.

Edit: Actually I find it really hard to figure out how to make it work, Tables.jl does not seem to speak to my intuition

julia> jlboost(Tables.table([A y], header=[:A1, :A2, :A3, :y]), :y)
ERROR: MethodError: no method matching view(::Tables.MatrixRow{Array{Float64,2}}, ::BitArray{1})

@xiaodaigh
Copy link
Owner Author

xiaodaigh commented Feb 12, 2020

Thanks for raising it. If you didn't, I wouldn't know what feature ppl would find useful. That's quite a different perspective, I created JLBoost partly because I didn't like the lack of support for DataFrames. I guess, some ppl would prefer matrices. So it's higher up on the cards

JLBoost supports Tables.jl so unless the recent API change broke it then it should work if you just defined three methods, see
https://github.com/xiaodaigh/JLBoost.jl#tablesjl-integration

If doing that would mean type piracy then I have to think about this. I think implementing nrow, ncol and view is a good idea in general anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants