-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Matrix Inputs #15
Comments
This would be great! I have always found DataFrames to be clunky and pretty much never use them. My inputs are often low-dimensional embeddings without any real names, making putting them in a dataframe just an extra step. Edit: Actually I find it really hard to figure out how to make it work, Tables.jl does not seem to speak to my intuition julia> jlboost(Tables.table([A y], header=[:A1, :A2, :A3, :y]), :y)
ERROR: MethodError: no method matching view(::Tables.MatrixRow{Array{Float64,2}}, ::BitArray{1}) |
Thanks for raising it. If you didn't, I wouldn't know what feature ppl would find useful. That's quite a different perspective, I created JLBoost partly because I didn't like the lack of support for DataFrames. I guess, some ppl would prefer matrices. So it's higher up on the cards JLBoost supports Tables.jl so unless the recent API change broke it then it should work if you just defined three methods, see If doing that would mean type piracy then I have to think about this. I think implementing |
No description provided.
The text was updated successfully, but these errors were encountered: