Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect now: doesn't always update (v2) #272

Open
dasgarner opened this issue Nov 17, 2022 · 0 comments
Open

Collect now: doesn't always update (v2) #272

dasgarner opened this issue Nov 17, 2022 · 0 comments
Assignees
Labels
Milestone

Comments

@dasgarner
Copy link
Member

dasgarner commented Nov 17, 2022

We started to notice some strange behaviour with the collect now functionality, particularly when creating a new layout, scheduling it and wanting to have that reflected on the display immediately.

We noticed that the XMR message was being pushed, but the player did not always update as expected.

The root cause of this is a race case between register and rf/schedule calls. This only started being an issue when we introduced the RF/Schedule checksums on the register return, which skip rf/schedule if the cache has not changed.

Because register/rf and schedule all get woken up at the same time, then rf/schedule are often analysed and ignored before the cache checksums have updated on schedule.


This is not a problem in v3

@dasgarner dasgarner added the bug label Nov 17, 2022
@dasgarner dasgarner added this to the 3 R307 milestone Nov 17, 2022
@dasgarner dasgarner self-assigned this Nov 17, 2022
dasgarner added a commit to dasgarner/xibo-dotnetclient that referenced this issue Nov 17, 2022
@dasgarner dasgarner modified the milestones: 3 R307, 2 R259 Nov 17, 2022
@dasgarner dasgarner changed the title Collect now: doesn't always update Collect now: doesn't always update (v2) Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant