Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A potential bug of NPD related to usage of libogg #37

Open
ash1852 opened this issue Sep 13, 2022 · 0 comments
Open

A potential bug of NPD related to usage of libogg #37

ash1852 opened this issue Sep 13, 2022 · 0 comments

Comments

@ash1852
Copy link

ash1852 commented Sep 13, 2022

Hi, I found a potential null pointer dereference bug in the project source code of opusfile related to usage of libogg, and I have shown the execution sequence of the program that may generate the bug on the graph below. The red text illustrates the steps that generate the bug, the red arrows represent the control flow.
os_lacing_expand
in short, the key step is not check the return value of call-statement relate to libogg.

opusfile/src/opusfile.c

Lines 2240 to 2246 in a46042a

static void op_buffer_continued_data(OggOpusFile *_of,ogg_page *_og){
ogg_packet op;
ogg_stream_pagein(&_of->os,_og);
/*Drain any packets that did end on this page (and ignore holes).
We only care about the continued packet data.*/
while(ogg_stream_packetout(&_of->os,&op));
}

would you help to check if this bug is true?thank you for your patience and effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant