-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include path fix for opus_multistream.h #41
Comments
any movement on this? its causing grief with our CI |
ive written a PR for this #47 hopefully it will get merged. The justification that this is the way it is supposed to work is false, because directly above the erroring line is: # include <ogg/ogg.h> If it was the case we were expected to add /usr/include/libraryname for every dependent lib to our includes, why isnt this <ogg.h>? |
I am quite certain the original explanation given be one dev is simply wrong here. The behaviour displayed by opusfile is not correct; I just ran into this issue with regards to SDL2_mixer. I did update all files via findutils and I can not find any file called opus_multistream.h. Right now I have no idea who is supposed to install the file, but whoever is ASSUMED to do so, doesn't do so, which causes problems. I haven't yet done a google search where opus_multistream.h can be found - interestingly, on my local filesystem, SDL2_mixer insists on having it:
Which is very confusing to me. Why is that one in VisualC? That sounds windows-related. Perhaps SDL2_mixer is also wrong. Either way, as this assumes to belong to "opus", opus should consider the issue here. Edit: I may have gotten the names wrong too. On my local system I have: libopusenc, opus, opusfile and opustools. Would be nice if these could all be merged into one-opus-to-rule-them-all really. |
Could this library get a bit of love, pretty please? The PR is just hanging at the moment - #47 |
I'm afraid I'm not a maintainer or anyone with permissions to the project. I just made a PR before. |
Why should you force the end user to include Yet Another Unnecessary Include Path in their project when it is possible to avoid it.
# include <opus_multistream.h>
to
# include <opus/opus_multistream.h>
Thank you.
See also:
#10
#20
The text was updated successfully, but these errors were encountered: