Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Integrate CMake source library" - Provide Code for Example CMake Library #138

Open
stellarpower opened this issue Jul 28, 2023 · 2 comments

Comments

@stellarpower
Copy link

Is your feature request related to a problem? Please describe.

In package/local_3rd_source_library.md, there are instructions for wrapping a CMake-based library from a local directory as an xmake package and then integrating this within our main project.

Describe the solution you'd like

Would it be possible to upload this (and maybe other) example packages so that users can work from them and work out how to copy the structure for a real package? Alternatively, it may make sense to change the example to use a real library that is available online (e.g. how we use things like liblzma, libpng in other examples). Then I could clone this package and try the code with my xmake project myself.

Describe alternatives you've considered

No response

Additional context

The reason I ask is that the library I need to wrap is not so simple. It would help to see have the example foo package and its CMakeLists to see what xmake is doing behind the scenes, and then see what I need to change to ensure I wrap my dependency properly. I think this might be useful for others given that CMake is a very large ecosystem now, and part of the reason I am switching to xmake is because there are too many ways to do the same thing and it becomes as hard to maintain as the code itself.

@stellarpower
Copy link
Author

My bad, my eye missed the section that say it's located here

Maybe I should edit the request! Could this line be moved a little higher so it's easier to see? I'll open a PR.

@waruqi
Copy link
Member

waruqi commented Jul 29, 2023

My bad, my eye missed the section that say it's located here

Maybe I should edit the request! Could this line be moved a little higher so it's easier to see? I'll open a PR.

sure, you can do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants