Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Argus package deletion #765

Open
wants to merge 5 commits into
base: feat/caduceus-testing
Choose a base branch
from
Open

Argus package deletion #765

wants to merge 5 commits into from

Conversation

maurafortino
Copy link
Contributor

@maurafortino maurafortino commented Jul 17, 2024 •
edited
Loading

What's Included:

  1. Deleted model and chrysom packages from argus and added them to ancla
  2. Updated code to reflect the package change
  3. updated bascule dependency to latest version

xmidt-org/ancla#230 must be merged first

dependabot bot added 2 commits July 11, 2024 15:52
@dependabot
automation(deps): bump xmidt-org/shared-go from 4.4.14 to 4.4.15 (#761)
23446a1 
Bumps [xmidt-org/shared-go](https://github.com/xmidt-org/shared-go) from 4.4.14 to 4.4.15.
- [Release notes](https://github.com/xmidt-org/shared-go/releases)
- [Commits](xmidt-org/shared-go@c36ac2a...9e2d208)

---
updated-dependencies:
- dependency-name: xmidt-org/shared-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
automation(deps): bump xmidt-org/shared-go from 4.4.15 to 4.4.16 (#763)
00bbe55 
Bumps [xmidt-org/shared-go](https://github.com/xmidt-org/shared-go) from 4.4.15 to 4.4.16.
- [Release notes](https://github.com/xmidt-org/shared-go/releases)
- [Commits](xmidt-org/shared-go@9e2d208...2cfcfbb)

---
updated-dependencies:
- dependency-name: xmidt-org/shared-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@guardrails GuardRails
Copy link

guardrails bot commented Jul 17, 2024

⚠️ We detected 2 security issues in this pull request:

Vulnerable Libraries (2)
Severity Details
High pkg:golang/github.com/xmidt-org/bascule@v0.11.6 upgrade to: > v0.11.6
High pkg:golang/github.com/xmidt-org/candlelight@v0.0.19 upgrade to: > v0.0.19

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@guardrails GuardRails
Copy link

guardrails bot commented Jul 17, 2024

⚠️ We detected 1 security issue in this pull request:

Vulnerable Libraries (1)
Severity Details
Medium pkg:golang/github.com/aws/aws-sdk-go@v1.54.19 - no patch available

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

maurafortino
maurafortino commented Jul 17, 2024
View reviewed changes
chrysom/README.md
Copy link
Contributor Author

@maurafortino maurafortino Jul 17, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all chrysom files have been moved to ancla: https://github.com/xmidt-org/ancla/pull/230/files#diff-9105f73596200cea76f6c60899a7235c60e3be288d6cfc1ca3e0b8ec06797cdc

maurafortino
maurafortino commented Jul 17, 2024
View reviewed changes
model/model.go
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

model/model.go has been moved to ancla: https://github.com/xmidt-org/ancla/pull/230/files#diff-a5ce247e55d5a20707517e34bef620f2eb369b4f9b8fa44fdfb2c18a702418e8

@guardrails GuardRails
Copy link

guardrails bot commented Jul 18, 2024 •
edited
Loading

⚠️ We detected 6 security issues in this pull request:

Vulnerable Libraries (6)
Severity Details
High pkg:golang/github.com/xmidt-org/ancla@v0.3.13-0.20240718193746-a3cd5a39560c upgrade to: > v0.3.13-0.20240718193746-a3cd5a39560c
Medium pkg:golang/github.com/aws/aws-sdk-go@v1.54.19 - no patch available
High pkg:golang/github.com/xmidt-org/bascule@v0.11.7 upgrade to: > v0.11.7
High pkg:golang/go.uber.org/fx@v1.22.0 upgrade to: > v1.22.0
High pkg:golang/github.com/prometheus/client_golang@v1.19.1 upgrade to: > v1.19.1
High pkg:golang/github.com/xmidt-org/candlelight@v0.0.19 upgrade to: > v0.0.19

More info on how to fix Vulnerable Libraries in Go.

👉 Go to the dashboard for detailed results.

📥 Happy? Share your feedback with us.

@maurafortino maurafortino self-assigned this Jul 18, 2024
@maurafortino maurafortino added dependencies Pull requests that update a dependency file feature new functionality proposal/implementation labels Jul 18, 2024
@maurafortino
Copy link
Contributor Author

do we want to merge into main or into a test branch?

@maurafortino maurafortino changed the base branch from main to feat/ancla-chrysom-package July 18, 2024 21:03
@maurafortino maurafortino changed the base branch from feat/ancla-chrysom-package to feat/caduceus-testing July 18, 2024 21:04
denopink
denopink approved these changes Jul 18, 2024
View reviewed changes
Copy link
Contributor

@denopink denopink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! lgtm 🍻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@denopink denopink denopink approved these changes

Assignees

@maurafortino maurafortino

Labels
dependencies Pull requests that update a dependency file feature new functionality proposal/implementation
Projects
XMiDT
Status: PRs: Approved
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurafortino @denopink