From d94ab8875fd1883b1dc3cad1d0b67720d4e22222 Mon Sep 17 00:00:00 2001 From: Brad Wilson Date: Wed, 4 Dec 2024 18:00:53 -0800 Subject: [PATCH] #426: Can't filter by traits on ITheoryDataRow --- src/xunit.runner.visualstudio/VsTestRunner.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/xunit.runner.visualstudio/VsTestRunner.cs b/src/xunit.runner.visualstudio/VsTestRunner.cs index 1b6b609..cb0a82d 100644 --- a/src/xunit.runner.visualstudio/VsTestRunner.cs +++ b/src/xunit.runner.visualstudio/VsTestRunner.cs @@ -207,9 +207,9 @@ async Task DiscoverTests( ConfigReader.Load(assembly.Configuration, assembly.AssemblyFileName, assembly.ConfigFileName, configWarnings); runSettings.CopyTo(assembly.Configuration); - // IDE users get pre-enumeated theories by default - if (testPlatformContext.DesignMode) - assembly.Configuration.PreEnumerateTheories ??= true; + // Pre-enumerate theories by default, so that we can see all traits, including those that come from + // ITheoryDataRow in v3. See: https://github.com/xunit/visualstudio.xunit/issues/426 + assembly.Configuration.PreEnumerateTheories ??= true; foreach (var warning in configWarnings) logger.LogWarning("{0}", warning);