-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plugin doesn't work if opcache.save_comments is disabled. #206
Comments
Only seeing this issue now. I am 100% in favour of fixing this, but it has significant consequences for any plugins already built that uses the current mechanism.
Having Opcache strip out comments is enough validation for me that this is not the ideal way to do WP hooks. |
Bug Description
Opache is caching in PHP, it takes your PHP code and compile it, so your site runs faster. For some large hosting companies they enable a flag called save_comments.
Quote from docs.
The wp-foo-bar use annotations to hook in filters and actions.
As comments are required for these filters / actions to hooked, when opache removes them, the plugin does not function.
Expected Behaviour
Plugin should work if opcache.save_comments is disabled, as many hosting companies may disable
save_comments
Steps to reproduce
Set opache.save_comments = false.
Acceptance criteria
Implementation brief
Simply use php hooks
QA testing instructions
Demo
Changelog entry
Original bug: xwp/unsplash-wp#195
Original Fix: xwp/unsplash-wp#197
Original bug reports - Settings won’t load on install
The text was updated successfully, but these errors were encountered: