Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delimiter-based tag detection UI updates are broken in mixed-mode; works fine if using Enter to complete. #1249

Open
3 tasks done
atownley opened this issue Oct 8, 2023 · 3 comments

Comments

@atownley
Copy link

atownley commented Oct 8, 2023

Prerequisites

  • I am running the latest version
  • I checked the documentation and found no answer
  • I checked to make sure that this issue has not already been filed

💥 Demo Page

https://jsbin.com/sikahusuha/edit?html,js,output
Also a jsfiddle here: https://jsfiddle.net/xw89qpar/

Explanation

  • What is the expected behavior?
  1. Enter a tag using the following: '#tag'

  2. the tag is displayed correctly in-line.

  3. Enter a tag using the following: '#mytag,'

  4. the "mytag" tag is displayed exactly as the first one.

  • What is happening instead?
    Enter a tag to be completed using the delimiters (I want basic punctuation to complete the tag in most cases), and if you enter the following, '#mytag,' the event is fired, and you get the tag created, but the UI doesn't update.

Here's a picture:
tagify-20231008-mix-mode-delimited-bug

I've looked through the code and I see where this happens, but I couldn't quickly find where the UI updates take place.

This doesn't seem like the expected behavior.

  • What error message are you getting?

No error message.

@yairEO
Copy link
Owner

yairEO commented Oct 10, 2023

Hi, mix-mode is different in many ways and one of them is no "delimiter-based tag detection" because everything is considered text which is a part of the tag.

Do you have an example of another tagging UI which does what you want?

@atownley
Copy link
Author

Hi. Yeah, I get it's tricky. I'm working around it for now, but I'm trying to get the UX as streamlined as possible.

What's strange is that I can see where in the code it correctly recognizes and adds the tag with the delimiters, but I couldn't figure out how to force the display formatting to be completed.

I think of all the sites/apps I've used, Slack actually does this the best. Some punctuation, it's immediate, but some it has to wait until you type the next character before it goes ahead. The nice thing about Slack vs. others is that there's no extra whitespace you have to delete between the tag/@ref and the punctuation. It's really annoying, and I hit this a lot with other tools.

I have things working without the delimiters at the moment, but it's a much better experience with them. And, like I said, the core code recognizes the situation and adds the tags, but the UI just isn't updated to show that it's happened.

Here's a quick capture – typo included ;) – of how it works on Slack.

Screen Recording 2023-10-10 at 5 21 25 PM

@yairEO
Copy link
Owner

yairEO commented Oct 28, 2024

Hi @atownley - checking up if things went well at the end with your Tagify setup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants