Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential histogram bucket overcounting #31

Open
kriskowal opened this issue Feb 10, 2020 · 0 comments
Open

Potential histogram bucket overcounting #31

kriskowal opened this issue Feb 10, 2020 · 0 comments

Comments

@kriskowal
Copy link

kriskowal commented Feb 10, 2020

Tracking on yarpc/yarpc-go#1882, we’ve disabled a couple flappy tests because due to intermittent over-counting in the latency histogram buckets.

These tests create a single request for the lifetime of the metrics graph. They assert that one request should appear in a latency histogram bucket. It’s usually just one. Occasionally in CI, tests would fail with more than one counted request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant