Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Table column reordering + always render sort icons #1479

Merged
merged 3 commits into from
Sep 28, 2021

Conversation

daniellevinson
Copy link
Member

@daniellevinson daniellevinson commented Sep 24, 2021

Description

Table column reordering fires a click event, similar to adopted-ember-addons/ember-sortable#405

Proposed Changes

  • attach click listener to ol
  • other cosmetics: always render Denali sort arrows to avoid possible column width change on hover

Screenshots

Screen Shot 2021-09-24 at 10 59 54 AM

License

I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.

@daniellevinson daniellevinson marked this pull request as ready for review September 24, 2021 21:22
Copy link
Contributor

@jkusa jkusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After speaking with the design team, they suggested using a solid icon.

packages/core/addon/components/navi-table-sort-icon.hbs Outdated Show resolved Hide resolved
Co-authored-by: Jon Kilroy <jkilroy@gmail.com>
@daniellevinson
Copy link
Member Author

updated screenshot:

Screen Shot 2021-09-28 at 11 24 50 AM

@daniellevinson daniellevinson merged commit 0c84ab8 into master Sep 28, 2021
@daniellevinson daniellevinson deleted the fix-table-reorder branch September 28, 2021 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants