Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Map::Insert breaks API safety rules #193

Open
FlareFlo opened this issue May 20, 2024 · 1 comment
Open

Map::Insert breaks API safety rules #193

FlareFlo opened this issue May 20, 2024 · 1 comment

Comments

@FlareFlo
Copy link

A safe API should never cause UB, implement an unsafe function like insert_unchecked instead.
@yegor256
Copy link
Owner

@FlareFlo thanks! Are you interested in submitting a pull request for this?

FlareFlo added a commit to FlareFlo/micromap that referenced this issue May 20, 2024
@FlareFlo
Always check bounds on inserting, no UB necessary fixed yegor256#193
51a9d86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yegor256 @FlareFlo