Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fit the artworks to screen #99

Open
yellowbluesky opened this issue May 12, 2020 · 0 comments
Open

Fit the artworks to screen #99

yellowbluesky opened this issue May 12, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@yellowbluesky
Copy link
Owner

A user has reported that on their very tall phone, landscape art does not look good requiring a lot of scrolling to see the entire artwork.

This could be implemented by somehow adding letterboxes or pillars to the artwork. I can override openFile() in PixivArtProvider, and apply the fitting there, thus preserving the original artwork.

I can take this a step further by adding a slider for how pillars the app should add. E.g. a slider maxed out would result in a tiny landscape artwork in the center of a portrait screen, which a slider halfway would result in the artwork occoupying mostly the center of the screen with some excess hanging off either side.

An issue would be if the user has rotation enabled on their home screens. I can provide only one copy of the artwork to Muzei (they keep its own local copy), so i can only provide one orientation of scaling

@yellowbluesky yellowbluesky added the enhancement New feature or request label May 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant