You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The comments were not addressed by the authors of warp-tls, but I believe that that they are valid points that reveal shortcomings in the current implementation. I recommend reading the original comments since it is very well explained. My understanding is that there are 2 issues:
A single IORef should be used instead of multiple IORefs (to avoid race condition by allowing atomic update)
The API should encourage proper use of certificate chains
Thank you
The text was updated successfully, but these errors were encountered:
@vdukhovni left some very insightful comments on the pull request Add the ability to load TLS credentials from IORefs:
#806 (review)
The comments were not addressed by the authors of warp-tls, but I believe that that they are valid points that reveal shortcomings in the current implementation. I recommend reading the original comments since it is very well explained. My understanding is that there are 2 issues:
IORef
should be used instead of multipleIORef
s (to avoid race condition by allowing atomic update)Thank you
The text was updated successfully, but these errors were encountered: