Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create interfaces for repositories #119

Open
roxblnfk opened this issue Jul 15, 2020 · 4 comments
Open

Create interfaces for repositories #119

roxblnfk opened this issue Jul 15, 2020 · 4 comments

Comments

@roxblnfk
Copy link
Member

I think it is good practice to use interfaces for repositories.

Repository methods already return DataReaderInterface objects (this gives us independence from DBAL), it remains only to describe their API in the interfaces.

@samdark
Copy link
Member

samdark commented Jul 15, 2020

Do you mean a common interface or repository-specific interfaces?

@terabytesoftw
Copy link
Member

Common interface with ooerations more used, created, modify, delete, find, etc.

@roxblnfk
Copy link
Member Author

Do you mean a common interface or repository-specific interfaces?

It is good to have a common interface in the context of ORM and other common cases.
However in the context of this repository i mean only repository-specific interfaces.

@samdark
Copy link
Member

samdark commented Jul 15, 2020

  1. Who would be users/clients of these interfaces?
  2. Would these interfaces separate system boundaries?
  3. Would there be multiple implementations of these interfaces?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants