Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote Selection Ribbon Doesn't Match That Remote User's Version #8

Open
seflless opened this issue Dec 13, 2021 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@seflless
Copy link

The selection ribbon doesn't fill to the right on the first line of multiple selections, for the remote user.

To Reproduce
Steps to reproduce the behavior:

  1. Use Google Chrome to open demo page in two tabs, put each tab's window side by side, left and right
  2. Set the following as the editor content:
const i = 10;
const j = i+1;
  1. On the left tab select from just after the ; on the first line, through to the last ; on the second line
  2. You should be seeing something like the following
    code-mirror-ribbon

Expected behavior
Ribbon for the remainder of the top line in a remote user's multi-line selection should match what the remote user sees. See rounded rectangle on the right of the above screenshot

Environment Information

@seflless seflless added the bug Something isn't working label Dec 13, 2021
@seflless
Copy link
Author

@dmonad Could you give me some pointers to where the logic/data-structures are for the awareness protocol related to text selection?

@dmonad
Copy link
Member

dmonad commented Dec 14, 2021

Hi @seflless, This is located in the y-protocols package.

@dmonad
Copy link
Member

dmonad commented Mar 25, 2022

I fixed this issue in y-codemirror. The fix, however, is quite complicated and required some extensive logic. I'll leave this issue open as I don't think it's too important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants