You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The command typings install is executed when installing the package. This causes builds to fail as typings is listed under "devDepenencies" and is therefore not installed.
If this was fixed by moving typings to "dependencies", it will likely cause issues because the typings for es6-shim modify the global namespace and will collide with declarations provided by TypeScript itself such as when specifying the lib option in tsconfig.compilerOptions.
Since es6-shim is not a dependency, its typings should also not be required. In general, polyfill typings, including those provided by npm:@types packages should be avoided where at all possible in favour of the tsconfig.compilerOptions.lib
The text was updated successfully, but these errors were encountered:
aluanhaddad
added a commit
to aluanhaddad/angular2-truncate
that referenced
this issue
Mar 1, 2017
The command
typings install
is executed when installing the package. This causes builds to fail as typings is listed under"devDepenencies"
and is therefore not installed.If this was fixed by moving typings to
"dependencies"
, it will likely cause issues because the typings for es6-shim modify the global namespace and will collide with declarations provided by TypeScript itself such as when specifying the lib option intsconfig.compilerOptions
.Since
es6-shim
is not a dependency, its typings should also not be required. In general, polyfill typings, including those provided by npm:@types packages should be avoided where at all possible in favour of thetsconfig.compilerOptions.lib
The text was updated successfully, but these errors were encountered: