Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings install is run on postinstall causing build to fail. #5

Open
aluanhaddad opened this issue Mar 1, 2017 · 0 comments · May be fixed by #6
Open

typings install is run on postinstall causing build to fail. #5

aluanhaddad opened this issue Mar 1, 2017 · 0 comments · May be fixed by #6

Comments

@aluanhaddad
Copy link

aluanhaddad commented Mar 1, 2017

The command typings install is executed when installing the package. This causes builds to fail as typings is listed under "devDepenencies" and is therefore not installed.

If this was fixed by moving typings to "dependencies", it will likely cause issues because the typings for es6-shim modify the global namespace and will collide with declarations provided by TypeScript itself such as when specifying the lib option in tsconfig.compilerOptions.

Since es6-shim is not a dependency, its typings should also not be required. In general, polyfill typings, including those provided by npm:@types packages should be avoided where at all possible in favour of the tsconfig.compilerOptions.lib

aluanhaddad added a commit to aluanhaddad/angular2-truncate that referenced this issue Mar 1, 2017
@aluanhaddad aluanhaddad linked a pull request Mar 1, 2017 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant