picture can't be accessed with document.name #4
Comments
yoavweiss
pushed a commit
that referenced
this issue
Jul 29, 2013
…w from WebKit This change covers a set of smaller fixes that were landed in WebKit regarding to shape-inside on regions and content overflow from shape-inside. Merged revisions: - #1 http://trac.webkit.org/changeset/148975 - #2 http://trac.webkit.org/changeset/149857 - #3 http://trac.webkit.org/changeset/150027 - #4 http://trac.webkit.org/changeset/150375 - #5 http://trac.webkit.org/changeset/150478 - #6 http://trac.webkit.org/changeset/151570 - #7 http://trac.webkit.org/changeset/151652 - #8 http://trac.webkit.org/changeset/151703 - #9 http://trac.webkit.org/changeset/152772 - #10 http://trac.webkit.org/changeset/152904 - #11 http://trac.webkit.org/changeset/152906 - #12 http://trac.webkit.org/changeset/152925 - #13 http://trac.webkit.org/changeset/153053 R=eric@chromium.org BUG=262269 Review URL: https://chromiumcodereview.appspot.com/19865002 git-svn-id: svn://svn.chromium.org/blink/trunk@155098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Jan 13, 2014
…oading. We ought to take account of the 'param' element parsing behavior that happens in 'HTMLObjectElement'. This patch moves the pluginIsLoadable check to make that happen. To avoid 'setTimeout' in the test, and to align with the spec[1], this patch also starts dispatching an 'error' event on load failure for 'object' elements. [1]: #4.6 ("If the load failed...") of http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#the-object-element BUG=320796 R=tsepez@chromium.org,abarth@chromium.org Review URL: https://codereview.chromium.org/76303002 git-svn-id: svn://svn.chromium.org/blink/trunk@164952 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Feb 2, 2014
This switches fastMalloc to PartitionAlloc for Android. Previously, we only used PartitionAlloc for fastMalloc on Mac OS X. According to primiano's measurements, this CL should improve PLT performance on Android by 7%. See referenced bug for details. alexa_us on N10 with default alloc (without # ms/page PSS Dirty #1 227.6 60410 44904 #2 226.1 61547 46008 #3 222.4 55595 40072 #4 224.2 57293 41728 AVG 225.1 58711 43178 alexa_us on N10 with partalloc # ms/page PSS Dirty #1 204.68 54862 39456 #2 208.73 59240 43844 #3 208.57 55164 39788 #4 217.28 58280 42904 AVG 209.81 56886 41498 BUG=312725 R=tonyg@chromium.org Review URL: https://codereview.chromium.org/148013010 git-svn-id: svn://svn.chromium.org/blink/trunk@166271 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Feb 5, 2014
…mpatible to tcmalloc R=esprehn@chromium.org TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash. ********** Crash dump: ********** Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys' pid: 3431, tid: 3444 >>> org.chromium.content_shell_apk:sandboxed_process1 <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039 Stack frame #00 pc 02263b44 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15 Stack frame #1 pc 0226ccd8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120 Stack frame #2 pc 0227584c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0 Stack frame #3 pc 02277698 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166 Stack frame #4 pc 02277898 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209 Stack frame #5 pc 0229f914 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569 Stack frame #6 pc 0158af50 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0 Stack frame #7 pc 0158aff8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305 Stack frame #8 pc 01166dac /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572 Stack frame #9 pc 0116b7a8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0 Stack frame #10 pc 0117e424 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453 Stack frame #11 pc 0117ea88 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767 Stack frame #12 pc 0158891c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0 Stack frame #13 pc 01589da0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876 Stack frame #14 pc 01589f3c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49 Stack frame #15 pc 00d07e70 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #16 pc 015770bc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #17 pc 017bdd20 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47 Stack frame #18 pc 017bddc8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219 Stack frame #19 pc 00eb86d8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110 Stack frame #20 pc 01024b5c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443 Stack frame #21 pc 010304c8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971 Stack frame #22 pc 010305dc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845 Stack frame #23 pc 00fb12f8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875 Stack frame #24 pc 00fb1b78 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076 Stack frame #25 pc 00fb1bd0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0 Review URL: https://codereview.chromium.org/143903018 git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 27, 2014
…dereview.chromium.org/183793002/) Reason for revert: Possibly causing content_browsertests EndToEnd to fail. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio Output: [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x000000a593be base::debug::StackTrace::StackTrace() #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9c3e4ab4a0 <unknown> #3 0x7f9c3e55da43 __poll #4 0x7f9c42aabff6 <unknown> #5 0x7f9c42aac124 g_main_context_iteration #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() #7 0x000000a8e802 base::RunLoop::Run() #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() Original issue's description: > Make start/stop loading notifications per-frame > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 TBR=abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/215533004 git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 28, 2014
…ttps://codereview.chromium.org/215533004/) Reason for revert: r170192 was not a culprit. Original issue's description: > Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/) > > Reason for revert: > Possibly causing content_browsertests EndToEnd to fail. > > See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio > > Output: > [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) > [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x000000a593be base::debug::StackTrace::StackTrace() > #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f9c3e4ab4a0 <unknown> > #3 0x7f9c3e55da43 __poll > #4 0x7f9c42aabff6 <unknown> > #5 0x7f9c42aac124 g_main_context_iteration > #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() > #7 0x000000a8e802 base::RunLoop::Run() > #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() > > Original issue's description: > > Make start/stop loading notifications per-frame > > > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > > > BUG=347643 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 > > TBR=abarth@chromium.org,japhet@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218 TBR=abarth@chromium.org,japhet@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/216083002 git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 28, 2014
…of a pointer (https://codereview.chromium.org/209713003/) Also reverting dependent patch https://codereview.chromium.org/213543004 Reason for revert: Likely to have caused memory leaks: http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 (1) Direct leak of 32 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (2) Indirect leak of 40 byte(s) in 1 object(s) allocated from: #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 (3) Indirect leak of 24 byte(s) in 1 object(s) allocated from: #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 Original issue's description: > Make DOMWrapperWorld::current() return a reference instead of a pointer > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > BUG=341032 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=341032 Review URL: https://codereview.chromium.org/217053007 git-svn-id: svn://svn.chromium.org/blink/trunk@170357 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 31, 2014
This is a revert of the revert of r170261. r170261 was reverted because it introduced new memory leaks, but the leaks were false-positive. > Revert of Make DOMWrapperWorld::current() return a reference instead of a pointer (https://codereview.chromium.org/209713003/) > > Also reverting dependent patch https://codereview.chromium.org/213543004 > > Reason for revert: > Likely to have caused memory leaks: > http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%2BLSan%20Tests%20%282%29/builds/989/steps/browser_tests/logs/stdio#failure1 > > (1) > Direct leak of 32 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9bdfd8a in WebCore::V8PerContextDataHolder::install(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:56 > #2 0x9bdfa06 in WebCore::V8PerContextData::V8PerContextData(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.cpp:108 > #3 0x9bc1afd in WebCore::V8PerContextData::create(v8::Handle<v8::Context>, WTF::PassRefPtr<WebCore::DOMWrapperWorld>) third_party/WebKit/Source/bindings/v8/V8PerContextData.h:66:16 > #4 0x9be64fc in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (2) > Indirect leak of 40 byte(s) in 1 object(s) allocated from: > #0 0x4b50d1 in operator new(unsigned long) /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_new_delete.cc:62 > #1 0x9b2ee18 in operator new third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:59:22 > #2 0x9b2ee18 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > #3 0x9be64e7 in WebCore::V8PerIsolateData::ensureDomInJSContext() third_party/WebKit/Source/bindings/v8/V8PerIsolateData.cpp:132 > > (3) > Indirect leak of 24 byte(s) in 1 object(s) allocated from: > #0 0x4b46c1 in __interceptor_malloc /usr/local/google/home/hwennborg/chromium/src/third_party/llvm/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:75 > #1 0x62caf0a in partitionAllocGenericFlags third_party/WebKit/Source/wtf/PartitionAlloc.h:533 > #2 0x62caf0a in partitionAllocGeneric third_party/WebKit/Source/wtf/PartitionAlloc.h:549 > #3 0x62caf0a in WTF::fastMalloc(unsigned long) third_party/WebKit/Source/wtf/FastMalloc.cpp:125 > #4 0x9b2ed61 in operator new third_party/WebKit/Source/wtf/RefCounted.h:175 > #5 0x9b2ed61 in WebCore::DOMWrapperWorld::create(int, int) third_party/WebKit/Source/bindings/v8/DOMWrapperWorld.cpp:53 > > Original issue's description: > > Make DOMWrapperWorld::current() return a reference instead of a pointer > > > > Now that it's guaranteed that DOMWrapperWorld is not 0 at any given time, we can make it a reference instead of a pointer. > > > > BUG=341032 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170261 > > TBR=jochen@chromium.org,dcarney@chromium.org,abarth@chromium.org,haraken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=341032 > > Review URL: https://codereview.chromium.org/217053007 TBR=enne@chromium.org Review URL: https://codereview.chromium.org/218813002 git-svn-id: svn://svn.chromium.org/blink/trunk@170424 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Jun 16, 2014
…//codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Jun 16, 2014
…ax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339723002 git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Aug 7, 2014
…ructed Currently an unresolved Promise on RespondWithObserver is forcibly rejected when the RespondWithObserver is destructed. This means that an unresolved Promise registered with fetchEvent.respondWith() is forcibly rejected when the fetchEvent is destructed. This behavior is not good because it makes GC observable. (For more details, see comment #2 and #4 in the CL discussion.) Given the above, this CL stops rejecting an unresolved Promise in RespondWithObserver's destructor. Also this CL removes a test that were testing the behavior. The removed test should hang after this change (because an unresolved Promise is never resolved nor rejected). BUG=400645 Review URL: https://codereview.chromium.org/442183003 git-svn-id: svn://svn.chromium.org/blink/trunk@179695 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Aug 19, 2014
…rror (patchset #4 of https://codereview.chromium.org/478223002/) Reason for revert: It looks like this broke a number of Chromium-side browser tests: See http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/3608 for example. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20Blink&testType=browser_tests&tests=ExtensionBrowserTest.RSSParseFeedInvalidFeed1,ExtensionBrowserTest.RSSParseFeedInvalidFeed2,ExtensionBrowserTest.RSSParseFeedInvalidFeed3,ExtensionBrowserTest.RSSParseFeedInvalidFeed4,ExtensionBrowserTest.RSSParseFeedValidFeed0,ExtensionBrowserTest.RSSParseFeedValidFeed2,ExtensionBrowserTest.RSSParseFeedValidFeed3,ExtensionBrowserTest.RSSParseFeedValidFeed4,ExtensionBrowserTest.RSSParseFeedValidFeed5,ExtensionBrowserTest.RSSParseFeedValidFeed6,ExtensionBrowserTest.RSSParseFeedValidFeedNoLinks for all the broken tests. Original issue's description: > XMLHttpRequest::overrideMimeType should throw InvalidStateError > > Before this CL, XMLHttpRequest accepted |overrideMimeType| regardless > of its state. This is not conformant to the current spec: > http://www.w3.org/TR/XMLHttpRequest2/#the-overridemimetype-method > > This CL changes it to throw InvalidStateError when the state > is LOADING or DONE, which aligns to the spec. > > BUG=402375 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180440 TBR=tyoshino@chromium.org,abarth@chromium.org,haraken@chromium.org,kouhei@chromium.org NOTREECHECKS=true NOTRY=true BUG=402375 Review URL: https://codereview.chromium.org/486703002 git-svn-id: svn://svn.chromium.org/blink/trunk@180455 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 8, 2014
… more targeted. (patchset #4 of https://codereview.chromium.org/506553004/) Reason for revert: This seems to be asserting in many PPAPI tests. For example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=OutOfProcessPPAPITest.FlashFullscreen&testType=browser_tests Original issue's description: > Make the compositing assert disabler for paint invalidation more targeted. > > BUG=360286 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180997 TBR=abarth@chromium.org,chrishtr@chromium.org NOTREECHECKS=true NOTRY=true BUG=360286 Review URL: https://codereview.chromium.org/516603003 git-svn-id: svn://svn.chromium.org/blink/trunk@181025 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 8, 2014
…01 of https://codereview.chromium.org/516843004/) Reason for revert: The test crash-on-querying-event-path.html is unacceptably flaky. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#group=@ToT%20Blink&tests=http%2Ftests%2Fdom%2Fcrash-on-querying-event-path.html&testType=layout-tests Original issue's description: > Fix crash when accessing Event::path(). > > (A more elaborate account of the details is found in the bug report.) > > BUG=400476 > R=haraken@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181200 TBR=haraken@chromium.org,vogelheim@chromium.org NOTREECHECKS=true NOTRY=true BUG=400476 Review URL: https://codereview.chromium.org/532593002 git-svn-id: svn://svn.chromium.org/blink/trunk@181205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 9, 2014
…1 of https://codereview.chromium.org/481453003/) Reason for revert: Broke build http://build.chromium.org/p/chromium.webkit/builders/GPU%20Mac%20Builder/builds/19956 Original issue's description: > Add FontFaceDescriptors IDL dictionary > > To follow the spec[1]. This is the first place to use IDL dictionary > execept for testing, so this CL also includes build related changes. > Existing tests(e.g. fast/css/fontface-constructor-error.html) should > cover this change. > > [1] http://dev.w3.org/csswg/css-font-loading/#fontface-interface > > BUG=403150 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181610 TBR=haraken@chromium.org,ksakamoto@chromium.org,bashi@chromium.org NOTREECHECKS=true NOTRY=true BUG=403150 Review URL: https://codereview.chromium.org/551873004 git-svn-id: svn://svn.chromium.org/blink/trunk@181612 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 18, 2014
…rror (patchset #4 id:60001 of https://codereview.chromium.org/571843003/) Reason for revert: WebServiceWorkerResponse's status is not initialised. This may cause problems. I will re-land this patch after https://codereview.chromium.org/575153002/ is submitted. Original issue's description: > [ServivceWorker] Treat rejecting respondWith as a Network Error > > Chromium side change is this: https://codereview.chromium.org/574643003/ > > > BUG=411173 > TEST=layouttest http/tests/serviceworker/ > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182147 TBR=yhirano@chromium.org,mkwst@chromium.org,tkent@chromium.org,nhiroki@chromium.org NOTREECHECKS=true NOTRY=true BUG=411173 Review URL: https://codereview.chromium.org/580993002 git-svn-id: svn://svn.chromium.org/blink/trunk@182204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 19, 2014
… Network Error (patchset #1 id:1 of https://codereview.chromium.org/580993002/) Reason for revert: Landed the patch to initialize WebServiceWorkerResponse's status. https://codereview.chromium.org/575153002/ Original issue's description: > Revert of [ServivceWorker] Treat rejecting respondWith as a Network Error (patchset #4 id:60001 of https://codereview.chromium.org/571843003/) > > Reason for revert: > WebServiceWorkerResponse's status is not initialised. > This may cause problems. > > I will re-land this patch after https://codereview.chromium.org/575153002/ is submitted. > > Original issue's description: > > [ServivceWorker] Treat rejecting respondWith as a Network Error > > > > Chromium side change is this: https://codereview.chromium.org/574643003/ > > > > > > BUG=411173 > > TEST=layouttest http/tests/serviceworker/ > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182147 > > TBR=yhirano@chromium.org,mkwst@chromium.org,tkent@chromium.org,nhiroki@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=411173 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182204 TBR=yhirano@chromium.org,mkwst@chromium.org,tkent@chromium.org,nhiroki@chromium.org NOTREECHECKS=true NOTRY=true BUG=411173 Review URL: https://codereview.chromium.org/585733002 git-svn-id: svn://svn.chromium.org/blink/trunk@182290 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 23, 2014
…chset #4 id:120001 of https://codereview.chromium.org/581683002/) Reason for revert: Broke developer builds on os x: https://code.google.com/p/chromium/issues/detail?id=416715 Original issue's description: > Expanding Type Traits to make Vector use mem ops more. > > Vector has several code paths depending on whether the encapsulated > object can be handled with memmove/memcpu/memset or not, and those > are used by many objects. Unfortunately that requires manual hinting > in each class because the type traits used are not strong enough. > > By using type trait functions available in all modern compilers it's > possible to more intelligently select the most optimal code path. > > Preferably the code would use the new type traits in C++ 11 but > unfortunately that requires a modern c++ library. Luckily, those > libraries are mostly just thin wrappers on top of de facto-standard > compiler extension functions anyway. > > With clang this cuts away 105 KB of machine code in blink. Mostly by > no longer needing copy constructor and assignment operators in many > classes so those can be stripped from the binary. > > With gcc the changes are differently. The binary is smaller but only > by 5 KB. It's clear that many Vector methods have become more compact but > it seems gcc compensated by spending that space elsewhere (more inlining?). > > I don't have as good measurement tools for Visual Studio but there was no > huge difference in footprint. > > Performance, all this is from a noisy development computer with a > non-stable cpu clock frequency (turbo ftl...): > > In LayoutTests most changes are within noise levels. But it looks like > large tables and flexboxes might be 1-5% faster. In ParserTests > html5-full-render (macro-benchmark) became 2-3% faster. > > clang footprint numbers: > Total change: -109940 bytes > =========================== > 14 added, totalling +3397 bytes across 8 sources > 19 removed, totalling -13302 bytes across 6 sources > 8 grown, for a net change of +578 bytes (2268 bytes before, 2846 bytes after) across 6 sources > 230 shrunk, for a net change of -100613 bytes (190909 bytes before, 90296 bytes after) across 49 sources > > Biggest changes: > -84410 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/wtf/Vector.h - (gained 784, lost 85194) > -6934 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/wtf/Deque.h - (gained 0, lost 6934) > -2267 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/animation/css/CSSAnimationData.cpp - (gained 904, lost 3171) > ... > +245 - Source: /home/bratell/src/chromium/src/third_party/WebKit/Source/core/svg/animation/SVGSMILElement.cpp - (gained 245, lost 0) > > BUG= > R=jochen@chromium.org > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182427 TBR=jochen@chromium.org,thakis@chomium.org,bratell@opera.com NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/594763002 git-svn-id: svn://svn.chromium.org/blink/trunk@182459 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 24, 2014
…ated database thread (patchset #4 id:60001 of https://codereview.chromium.org/596083005/) Reason for revert: This causes a lot of database layout test failures on the buildbots. Reverting. Original issue's description: > DatabaseBackend should not post a task to an already terminated database thread > > Currently some methods of DatabaseBackend post a task to a database thread without checking DatabaseThread::terminationRequested(). Consequently, the task can be posted to an already terminated database thread. > > This is problematic but by accident isn't currently causing any real issue (for some reason). This begins to cause an issue when I destruct DatabaseThread::m_thread promptly after the database thread processed a cleanup task (See https://codereview.chromium.org/589363002). > > This CL adds the necessary DatabaseThread::terminationRequested()s before DatabaseBackend posts a task to the database thread. > > BUG=340522 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182552 TBR=oilpan-reviews@chromium.org,tkent@chromium.org,haraken@chromium.org NOTREECHECKS=true NOTRY=true BUG=340522 Review URL: https://codereview.chromium.org/593423002 git-svn-id: svn://svn.chromium.org/blink/trunk@182564 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
e.g.
...returns
false, should betrueThe text was updated successfully, but these errors were encountered: