all matching sources and fallbacks are downloaded #6
Comments
|
Fixed at 5426a23 |
yoavweiss
pushed a commit
that referenced
this issue
Jul 29, 2013
…w from WebKit This change covers a set of smaller fixes that were landed in WebKit regarding to shape-inside on regions and content overflow from shape-inside. Merged revisions: - #1 http://trac.webkit.org/changeset/148975 - #2 http://trac.webkit.org/changeset/149857 - #3 http://trac.webkit.org/changeset/150027 - #4 http://trac.webkit.org/changeset/150375 - #5 http://trac.webkit.org/changeset/150478 - #6 http://trac.webkit.org/changeset/151570 - #7 http://trac.webkit.org/changeset/151652 - #8 http://trac.webkit.org/changeset/151703 - #9 http://trac.webkit.org/changeset/152772 - #10 http://trac.webkit.org/changeset/152904 - #11 http://trac.webkit.org/changeset/152906 - #12 http://trac.webkit.org/changeset/152925 - #13 http://trac.webkit.org/changeset/153053 R=eric@chromium.org BUG=262269 Review URL: https://chromiumcodereview.appspot.com/19865002 git-svn-id: svn://svn.chromium.org/blink/trunk@155098 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Feb 5, 2014
…mpatible to tcmalloc R=esprehn@chromium.org TEST=Compile Android build with Deep Memory Profiler support. Go to lenta.ru. Open some news pages. Should not crash. ********** Crash dump: ********** Build fingerprint: 'samsung/GT-I9100/GT-I9100:4.0.3/IML74K/XXLPQ:user/release-keys' pid: 3431, tid: 3444 >>> org.chromium.content_shell_apk:sandboxed_process1 <<< signal 11 (SIGSEGV), code 1 (SEGV_MAPERR), fault addr 00000039 Stack frame #00 pc 02263b44 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Abort in ../../third_party/tcmalloc/chromium/src/base/abort.cc:15 Stack frame #1 pc 0226ccd8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Log in ../../third_party/tcmalloc/chromium/src/internal_logging.cc:120 Stack frame #2 pc 0227584c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine InvalidFree in (null):0 Stack frame #3 pc 02277698 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free_with_callback in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1166 Stack frame #4 pc 02277898 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine do_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1209 Stack frame #5 pc 0229f914 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine tc_free in ../../third_party/tcmalloc/chromium/src/tcmalloc.cc:1569 Stack frame #6 pc 0158af50 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine error in (null):0 Stack frame #7 pc 0158aff8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine normalErrorHandler in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:1305 Stack frame #8 pc 01166dac /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __xmlRaiseError in ../../third_party/libxml/src/error.c:572 Stack frame #9 pc 0116b7a8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlFatalErr in (null):0 Stack frame #10 pc 0117e424 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseTryOrFinish in ../../third_party/libxml/src/parser.c:11453 Stack frame #11 pc 0117ea88 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine xmlParseChunk in ../../third_party/libxml/src/parser.c:11767 Stack frame #12 pc 0158891c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine parseChunk in (null):0 Stack frame #13 pc 01589da0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine doWrite in ../../third_party/WebKit/Source/core/xml/parser/XMLDocumentParser.cpp:876 Stack frame #14 pc 01589f3c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine append in ../../third_party/WebKit/Source/wtf/RefPtr.h:49 Stack frame #15 pc 00d07e70 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine setContent in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #16 pc 015770bc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXML in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:70 Stack frame #17 pc 017bdd20 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetter in ../../third_party/WebKit/Source/wtf/PassRefPtr.h:47 Stack frame #18 pc 017bddc8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine responseXMLAttributeGetterCallback in gen/blink/bindings/V8XMLHttpRequest.cpp:219 Stack frame #19 pc 00eb86d8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Call in ../../v8/src/arguments.cc:110 Stack frame #20 pc 01024b5c /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetPropertyWithCallback in ../../v8/src/objects.cc:443 Stack frame #21 pc 010304c8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:971 Stack frame #22 pc 010305dc /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine GetProperty in ../../v8/src/objects.cc:845 Stack frame #23 pc 00fb12f8 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine Load in ../../v8/src/ic.cc:875 Stack frame #24 pc 00fb1b78 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine __RT_impl_LoadIC_Miss in ../../v8/src/ic.cc:2076 Stack frame #25 pc 00fb1bd0 /data/data/org.chromium.content_shell_apk/lib/libcontent_shell_content_view.so: Routine LoadIC_Miss in (null):0 Review URL: https://codereview.chromium.org/143903018 git-svn-id: svn://svn.chromium.org/blink/trunk@166520 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 27, 2014
…dereview.chromium.org/183793002/) Reason for revert: Possibly causing content_browsertests EndToEnd to fail. See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio Output: [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x000000a593be base::debug::StackTrace::StackTrace() #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f9c3e4ab4a0 <unknown> #3 0x7f9c3e55da43 __poll #4 0x7f9c42aabff6 <unknown> #5 0x7f9c42aac124 g_main_context_iteration #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() #7 0x000000a8e802 base::RunLoop::Run() #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() Original issue's description: > Make start/stop loading notifications per-frame > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 TBR=abarth@chromium.org,japhet@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/215533004 git-svn-id: svn://svn.chromium.org/blink/trunk@170218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Mar 28, 2014
…ttps://codereview.chromium.org/215533004/) Reason for revert: r170192 was not a culprit. Original issue's description: > Revert of Make start/stop loading notifications per-frame (https://codereview.chromium.org/183793002/) > > Reason for revert: > Possibly causing content_browsertests EndToEnd to fail. > > See: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2095/steps/content_browsertests/logs/stdio > > Output: > [20917:20917:0327/122353:3268961829:INFO:CONSOLE(0)] "Uncaught TypeError: Cannot convert undefined or null to object", source: http://127.0.0.1:34379/files/web_ui_mojo.html (0) > [20917:20917:0327/122353:3269022437:INFO:CONSOLE(28)] "Uncaught TypeError: undefined is not a function", source: http://127.0.0.1:34379/files/web_ui_mojo.js (28) > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x000000a593be base::debug::StackTrace::StackTrace() > #1 0x000002bfc17b content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f9c3e4ab4a0 <unknown> > #3 0x7f9c3e55da43 __poll > #4 0x7f9c42aabff6 <unknown> > #5 0x7f9c42aac124 g_main_context_iteration > #6 0x000000aaaf5f base::MessagePumpGlib::RunWithDispatcher() > #7 0x000000a8e802 base::RunLoop::Run() > #8 0x00000058256e content::(anonymous namespace)::WebUIMojoTest_EndToEnd_Test::RunTestOnMainThread() > > Original issue's description: > > Make start/stop loading notifications per-frame > > > > Also, make ProgressTracker a frame-level concept rather than a page-level concept and merge it with FrameLoader's FrameProgressTracker helper. Send per-frame progress change notifications accordingly. > > > > This depends on https://codereview.chromium.org/180113003/ landing in chromium. > > > > BUG=347643 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170192 > > TBR=abarth@chromium.org,japhet@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=347643 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170218 TBR=abarth@chromium.org,japhet@chromium.org,enne@chromium.org NOTREECHECKS=true NOTRY=true BUG=347643 Review URL: https://codereview.chromium.org/216083002 git-svn-id: svn://svn.chromium.org/blink/trunk@170248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Jun 16, 2014
…//codereview.chromium.org/312683005/) Reason for revert: This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 BrowserTestBase signal handler received SIGTERM. Backtrace: #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7f2c232cd4a0 \u003Cunknown> #3 0x7f2c2337f313 __poll #4 0x7f2c240b6036 \u003Cunknown> #5 0x7f2c240b6164 g_main_context_iteration #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() #8 0x7f2c2a2f69d8 base::RunLoop::Run() #9 0x00000466bd59 content::RunThisRunLoop() #10 0x00000466c1b8 content::MessageLoopRunner::Run() #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() #12 0x0000011fdf00 MediaBrowserTest::RunTest() #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() ... Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. Original issue's description: > IDL: Support optional argument default value syntax > > Adds support for parsing default values of different types, but > only handles null default values when generating code. > > Replaces existing > > [Default=Null] optional SomeInterface arg > [Default=NullString] optional DOMString arg > > with the now equivalent > > optional SomeInterface arg = null > optional DOMString arg = null > > in IDL files, and drops support for those [Default] attributes. > > No changes to generated code. > > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339683002 git-svn-id: svn://svn.chromium.org/blink/trunk@176220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Jun 16, 2014
…ax (https://codereview.chromium.org/339683002/) Reason for revert: Revert the revert because the bot went green even without this revert, and other bots had no trouble. Original issue's description: > Revert of IDL: Support optional argument default value syntax (https://codereview.chromium.org/312683005/) > > Reason for revert: > This patch is the most likely candidate for browser test failures: http://build.chromium.org/p/chromium.webkit/builders/Linux%20Tests%20%28dbg%29/builds/2905 > > BrowserTestBase signal handler received SIGTERM. Backtrace: > #0 0x7f2c2a201a1d base::debug::StackTrace::StackTrace() > #1 0x00000460caf2 content::(anonymous namespace)::DumpStackTraceSignalHandler() > #2 0x7f2c232cd4a0 \u003Cunknown> > #3 0x7f2c2337f313 __poll > #4 0x7f2c240b6036 \u003Cunknown> > #5 0x7f2c240b6164 g_main_context_iteration > #6 0x7f2c2a1c9b45 base::MessagePumpGlib::Run() > #7 0x7f2c2a29eed7 base::MessageLoop::RunHandler() > #8 0x7f2c2a2f69d8 base::RunLoop::Run() > #9 0x00000466bd59 content::RunThisRunLoop() > #10 0x00000466c1b8 content::MessageLoopRunner::Run() > #11 0x000004610946 content::TitleWatcher::WaitAndGetTitle() > #12 0x0000011fdf00 MediaBrowserTest::RunTest() > #13 0x0000011fdc00 MediaBrowserTest::RunMediaTestPage() > #14 0x0000011ec98b EncryptedMediaTestBase::RunEncryptedMediaTestPage() > #15 0x0000011ee5fa EncryptedMediaTest::TestConfigChange() > #16 0x0000011eb73a EncryptedMediaTest_ConfigChangeVideo_Test::RunTestOnMainThread() > ... > > Please look into it. An alterate possible candidate is https://codereview.chromium.org/327553002 but I think that's less likely. > > Original issue's description: > > IDL: Support optional argument default value syntax > > > > Adds support for parsing default values of different types, but > > only handles null default values when generating code. > > > > Replaces existing > > > > [Default=Null] optional SomeInterface arg > > [Default=NullString] optional DOMString arg > > > > with the now equivalent > > > > optional SomeInterface arg = null > > optional DOMString arg = null > > > > in IDL files, and drops support for those [Default] attributes. > > > > No changes to generated code. > > > > BUG=258153 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176200 > > TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com > NOTREECHECKS=true > NOTRY=true > BUG=258153 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176220 TBR=nbarth@chromium.org,haraken@chromium.org,pavan.e@samsung.com,jsbell@chromium.org,jl@opera.com NOTREECHECKS=true NOTRY=true BUG=258153 Review URL: https://codereview.chromium.org/339723002 git-svn-id: svn://svn.chromium.org/blink/trunk@176231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 8, 2014
…ation (patchset #6 of https://codereview.chromium.org/480943002/) Reason for revert: This is crashing on Mac. Original issue's description: > Service Worker: Add tests for same-scope, new script registration > > Tests for Chromium patch: > https://codereview.chromium.org/506043002/ > > BUG=398355 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948 TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org NOTREECHECKS=true NOTRY=true BUG=398355 Review URL: https://codereview.chromium.org/512703002 git-svn-id: svn://svn.chromium.org/blink/trunk@180956 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 8, 2014
…n wrappers. (patchset #6 id:100001 of https://codereview.chromium.org/525353002/) Reason for revert: Reverting due to browser test failures. Original issue's description: > [oilpan]: optimize the way we allocate persistent handles in wrappers. > > The oilpan JS wrappers all have a persistent which is used to keep the wrapped object around while there is a javascript reference to it. Allocation of these wrapper persistents showed up in some of benchmarks. This change creates a new optimized WrapperPersistent which is allocated in blocks. This gives a speedup ranging between a few percent to 20% in some of the more wrapper intensive tests. > > R=ager@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181298 TBR=ager@chromium.org,haraken@chromium.org,oilpan-reviews@chromium.org,zerny@chromium.org,erik.corry@gmail.com,fdegans@chromium.org NOTREECHECKS=true NOTRY=true BUG=411240 Review URL: https://codereview.chromium.org/553483004 git-svn-id: svn://svn.chromium.org/blink/trunk@181553 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 9, 2014
…andles in wrappers. (patchset #6 id:100001 of https://codereview.chromium.org/52535 3002/)" Reland the wrapper persistent change using placement new for the constructor and no use of destructors. Also when constructing the object we make no assumption about the content of the slot. This reverts commit 1738b5c. R=ager@chromium.org, fdegans@chromium.org, haraken@chromium.org, oilpan-reviews@chromium.org, zerny@chromium.org BUG=411240 Review URL: https://codereview.chromium.org/556823003 git-svn-id: svn://svn.chromium.org/blink/trunk@181645 bbb929c8-8fbe-4397-9dbb-9b2b20218538
yoavweiss
pushed a commit
that referenced
this issue
Sep 12, 2014
…pt registration (patchset #1 id:1 of https://codereview.chromium.org/512703002/) Reason for revert: This crash will be fixed by https://codereview.chromium.org/556003006. Original issue's description: > Revert of Service Worker: Add tests for same-scope new script registration (patchset #6 of https://codereview.chromium.org/480943002/) > > Reason for revert: > This is crashing on Mac. > > Original issue's description: > > Service Worker: Add tests for same-scope, new script registration > > > > Tests for Chromium patch: > > https://codereview.chromium.org/506043002/ > > > > BUG=398355 > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180948 > > TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org > NOTREECHECKS=true > NOTRY=true > BUG=398355 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=180956 TBR=michaeln@chromium.org,nhiroki@chromium.org,falken@chromium.org,mlamouri@chromium.org NOTREECHECKS=true NOTRY=true BUG=398355 Review URL: https://codereview.chromium.org/547743003 git-svn-id: svn://svn.chromium.org/blink/trunk@181878 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given:
...all three images are downloaded
The text was updated successfully, but these errors were encountered: