Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truncated struct/arrays preview in Table #774

Open
Flunt1k opened this issue Sep 19, 2024 · 3 comments
Open

Fix truncated struct/arrays preview in Table #774

Flunt1k opened this issue Sep 19, 2024 · 3 comments
Assignees

Comments

@Flunt1k
Copy link
Collaborator

Flunt1k commented Sep 19, 2024

There is preview modal for truncated values, but it doesn't work for columns with struct or with arrays.

Screenshot 2024-09-19 at 12 30 42 PM
@Flunt1k Flunt1k self-assigned this Sep 19, 2024
@Flunt1k Flunt1k changed the title Fix struct/arrays preview in Tabel Fix truncated struct/arrays preview in Tabel Sep 19, 2024
@vrozaev vrozaev changed the title Fix truncated struct/arrays preview in Tabel Fix truncated struct/arrays preview in Table Sep 20, 2024
@vrozaev
Copy link
Collaborator

vrozaev commented Sep 20, 2024

SIG UI Weekly discussion:

  1. Need research, it's strange that array doesn't have "truncated" flag, we need to check why it's not there.
  2. Depends on result from 1 we can check this flag on parent array or check all array elements via recursion (recursion is a bad way, let's try to avoid this if possible).

@Krock21
Copy link
Member

Krock21 commented Sep 20, 2024

read_table result for the table: https://gist.github.com/Krock21/b7c2b7d39606b0d81bd9cd20959252de

@Krock21
Copy link
Member

Krock21 commented Sep 23, 2024

I suggest:

  1. If size is too big, don't check "truncated" flag and always show a button for full version
  2. Otherwise, recursively check "inc" flag and show a button if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants