Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion of nodes should be more intuitive #937

Open
4 tasks
Krock21 opened this issue Jan 6, 2025 · 0 comments
Open
4 tasks

Deletion of nodes should be more intuitive #937

Krock21 opened this issue Jan 6, 2025 · 0 comments
Assignees

Comments

@Krock21
Copy link
Member

Krock21 commented Jan 6, 2025

SIG UI suggestion:

We discussed an issue and decide that following changes should be sufficient to solve the problem:

  • On action button, change text from "Delete" to "Move to trash" in case if "Delete permanently" checkbox disabled
  • On modal window, change title from "Delete" to "Move to trash" in case if "Delete permanently" checkbox disabled
  • Change title of success notification from "Objects deleted" to "Objects moved"
  • In the success notification "Objects moved", show directory path where objects were moved, so users can go there and see them/undo

Original issue decsriptiuon

Currently, deleting nodes in UI shows:

  • Delete permanently checkbox, with no hint why is it different from "Delete"
  • Delete button, which is actually a "Move to trash" button
  • Confirmation notification with "Objects deleted" title and "Objects have been moved to the trash" description
Screenshot 2025-01-06 at 12 10 39 Screenshot 2025-01-06 at 12 11 01

Some users assume that clicking "Delete" deletes nodes, and then notice resource leaks in their accounts

We should make a clear distinction between "Delete" and "Move to trash", and show a path for the trash in the notification

So I suggest:

  1. Remove "Delete permanently" checkbox
  2. Instead of "Delete" button, show 2 buttons:
    • Move to trash
    • Delete permanently
  3. In the notification for "Move to trash", show trash directory path, so users can go there and see/undo
@vrozaev vrozaev assigned vitshev and vrozaev and unassigned vitshev Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants