You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently promdump uses separate flags to specify the YBA hostname (--yba_hostname / ‑‑yba_api_hostname) and the Prometheus URL (--url), both of which default to localhost.
When using YBA API mode on any system where TLS is configured, one or both of these flags will always have to be changed (or we have to skip host verification) because the hostname localhost should never match the hostname(s) on the certificates.
The flags used to specify connection information should be simplified to avoid having to specify the hostname in two different flags if it is the same (and it almost always will be).
Ideas:
Add a --hostname flag that can be used to set both the YBA hostname and the Prometheus hostname at the same time. Deprecate the --url flag and add --prometheus_hostname, --prometheus_port, --prometheus_username, --prometheus_password, --prometheus_use_tls, etc. to replace the --url flag. Each flag would have to have two variants, one for Prometheus and one for the YBA API. Some of these already exist for the YBA API.
Instead of using localhost as the default hostname, use os.Hostname() to get it. If we expect to need the fully qualified domain name (e.g. because the certificates don't list the short names of nodes), that will require more work as there's no trivial way to do this in Golang.
If --url is specified but --yba_hostname isn't, use the hostname from the --url flag.
Will need to think through which of the above would make for the best user experience (and we can always implement more than one).
The text was updated successfully, but these errors were encountered:
Currently promdump uses separate flags to specify the YBA hostname (
--yba_hostname
/‑‑yba_api_hostname
) and the Prometheus URL (--url
), both of which default tolocalhost
.When using YBA API mode on any system where TLS is configured, one or both of these flags will always have to be changed (or we have to skip host verification) because the hostname
localhost
should never match the hostname(s) on the certificates.The flags used to specify connection information should be simplified to avoid having to specify the hostname in two different flags if it is the same (and it almost always will be).
Ideas:
--hostname
flag that can be used to set both the YBA hostname and the Prometheus hostname at the same time. Deprecate the--url
flag and add--prometheus_hostname
,--prometheus_port
,--prometheus_username
,--prometheus_password
,--prometheus_use_tls
, etc. to replace the--url
flag. Each flag would have to have two variants, one for Prometheus and one for the YBA API. Some of these already exist for the YBA API.localhost
as the default hostname, useos.Hostname()
to get it. If we expect to need the fully qualified domain name (e.g. because the certificates don't list the short names of nodes), that will require more work as there's no trivial way to do this in Golang.--url
is specified but--yba_hostname
isn't, use the hostname from the--url
flag.Will need to think through which of the above would make for the best user experience (and we can always implement more than one).
The text was updated successfully, but these errors were encountered: