From 566707c5e09de5d41a92270f21c28b120c9100dc Mon Sep 17 00:00:00 2001 From: Christophe Moustier <52098262+Moustov@users.noreply.github.com> Date: Sun, 8 Jan 2023 23:06:34 +0100 Subject: [PATCH 1/3] 6b5 chord quality added from https://www.scales-chords.com/chord/piano/C%236b5 --- pychord/constants/qualities.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pychord/constants/qualities.py b/pychord/constants/qualities.py index 3bfa402..3b84dc0 100644 --- a/pychord/constants/qualities.py +++ b/pychord/constants/qualities.py @@ -22,6 +22,8 @@ ('sus', (0, 5, 7)), # 4 notes ('6', (0, 4, 7, 9)), + ('6b5', (0, 4, 6, 9)), # https://www.scales-chords.com/chord/piano/C%236b5 + ('6-5', (0, 4, 6, 9)), # https://www.scales-chords.com/chord/piano/C%236b5 ('7', (0, 4, 7, 10)), ('7-5', (0, 4, 6, 10)), ('7b5', (0, 4, 6, 10)), From e73481d6bacde3e9b921bdfc3b793a0d8bf46cef Mon Sep 17 00:00:00 2001 From: Christophe Moustier <52098262+Moustov@users.noreply.github.com> Date: Mon, 16 Jan 2023 18:57:27 +0100 Subject: [PATCH 2/3] fixing unit tests --- test/test_analyzer.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/test/test_analyzer.py b/test/test_analyzer.py index a3e16cc..24fb9eb 100644 --- a/test/test_analyzer.py +++ b/test/test_analyzer.py @@ -106,12 +106,12 @@ def test_add9(self): def test_m7b5(self): chords = find_chords_from_notes(["F#", "A", "C", "E"]) - self.assertEqual(chords, [Chord("F#m7-5"), Chord("Am6/F#")]) + self.assertEqual(chords, [Chord("F#m7-5"), Chord("Am6/F#"), Chord("C6b5/F#")]) def test_m7dim5(self): chords = find_chords_from_notes(["F#", "A", "C", "E"]) - self.assertEqual(chords, [Chord("F#m7-5"), Chord("Am6/F#")]) - + self.assertEqual(chords, [Chord("F#m7-5"), Chord("Am6/F#"), Chord("C6b5/F#")]) + def test_add4(self): chords = find_chords_from_notes(["C", "E", "F", "G"]) self.assertEqual(chords, [Chord("Cadd4")]) From 08ab003f73387ec9435205792d7ed0c2852ae033 Mon Sep 17 00:00:00 2001 From: Christophe Moustier <52098262+Moustov@users.noreply.github.com> Date: Mon, 16 Jan 2023 19:04:25 +0100 Subject: [PATCH 3/3] fixing test/test_analyzer.py:114:1 W293 blank line contains whitespace --- test/test_analyzer.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_analyzer.py b/test/test_analyzer.py index 24fb9eb..75ce6b6 100644 --- a/test/test_analyzer.py +++ b/test/test_analyzer.py @@ -111,7 +111,7 @@ def test_m7b5(self): def test_m7dim5(self): chords = find_chords_from_notes(["F#", "A", "C", "E"]) self.assertEqual(chords, [Chord("F#m7-5"), Chord("Am6/F#"), Chord("C6b5/F#")]) - + def test_add4(self): chords = find_chords_from_notes(["C", "E", "F", "G"]) self.assertEqual(chords, [Chord("Cadd4")])