Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize parameters location (running parameters vs config.py) #26

Open
zabealbe opened this issue Mar 15, 2021 · 0 comments
Open

Standardize parameters location (running parameters vs config.py) #26

zabealbe opened this issue Mar 15, 2021 · 0 comments
Labels
enhancement New feature or request low-priority I dont give a fuck about that at this point in time

Comments

@zabealbe
Copy link
Owner

Parameters location should be decided based on their portability.
For example for flatbuffers-generator: flatcc binary path is always the same? No, in github actions flatcc a musl precompiled binary pulled from a repo, placed in a directory that is not in PATH.
On the other hand network.json is in a standard path for the whole project, it doesn't matter if you run the project on a workstation, over github actions or on your own laptop, thus it should be specified on the config.py.

As a rule of thumb parameters that might change MUST be implemented as running parameters in such a way to avoid edits to config.py that might result to a commit that modifies the remote config.py.

@zabealbe zabealbe added the enhancement New feature or request label Mar 15, 2021
@zabealbe zabealbe added low-priority I dont give a fuck about that at this point in time and removed flatbuf-generator labels Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority I dont give a fuck about that at this point in time
Projects
None yet
Development

No branches or pull requests

2 participants