Update subprocess call in IsolatedEnvironment class and test case.- U…

…se capture_output in test case for "git --version".
zackees · Aug 19, 2024 · 690cbdc · 690cbdc
1 parent 7d7aa15
commit 690cbdc
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/isolated_environment/api.py b/src/isolated_environment/api.py
@@ -221,8 +221,10 @@ def run(self, cmd_list: list[str], **kwargs) -> subprocess.CompletedProcess:
             )
         ):
             cmd_list[0] = str(act_env.pip)
+        shell = kwargs.get("shell", False)
+        cmd_or_cmd_list = subprocess.list2cmdline(cmd_list) if shell else cmd_list
         cp = subprocess.run(
-            cmd_list,
+            cmd_or_cmd_list,
             env=env,
             check=check,
             text=text,

diff --git a/tests/test_git.py b/tests/test_git.py
@@ -53,7 +53,9 @@ def test_git_is_still_installed(self) -> None:
             )
             activated_env = iso_env.environment()
             # now create an inner environment without the static-ffmpeg
-            cp: subprocess.CompletedProcess = iso_env.run(["git", "--help"], shell=True)
+            cp: subprocess.CompletedProcess = iso_env.run(
+                ["git", "--version"], shell=True, capture_output=True
+            )
             if cp.returncode != 0:
                 warning_message = [
                     "git had some sort of a problem, dumping out the system"