-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
KeepassXC: freezes and org.freedesktop.Secret.IsLocked #88
Comments
Password not present
dbus-monitor
dbus-monitor
|
Password present
dbus-monitor
dbus-monitor
For comparison, dbus-monitor
|
@voidus Thanks for all the detailed info. I am the maintainer of GitHub CLI and I'm also wondering about the freezes and slow credential lookups that some of our users were experiencing (typically either under Windows proper or under WSL2). Do you have an idea of what the go-keyring could improve or change to avoid these types of hangs? |
Also would love to hear any thoughts on this |
I'm not sure, but I assume that either keepassxc or go-keyring aren't fully compliant with the spec. If someone has time, they could read into it and look at the dbus monitor output for anything amiss. |
I have a feeling that nobody here knows enough about the spec, maybe we could ask this in a forum or reddit or twitter bubble where there is a chance to find people who could help? |
FYI I get a similar issue using Supersonic (which uses go-keyring) while using KeepassXC as my secret service. It works the first time I connect, but if I quit the application and re-open it, after I put in my credentials, the application basically hangs, and I get the following error in the application logs:
|
This seems to be resolved with KeePassXC - Version 2.7.9 and gh version 2.49.2 (which uses go-keyring v0.2.4) Anybody seeing something similar? |
Heya 👋
I was checking out gh (the github cli) and it got stuck after running
gh auth login
. So I dug a little and localized the issue in the interaction between this library and keepassxc, which I use as a keyring.As far as I can tell, both this library and keepassxc are weird with the secret service protocol, so I'll cross-post it to their issue tracker.
While playring around, I've encountered unhandled errors and freeze.
Not sure about the freezes, but the secret service api spec this regarding IsLocked:
gh auth login
freezes instead of exiting, but it does get a new token from github and saves it. It doesn't seem to apply, but as far as I can tell, that's because it fails to read the secret from the store. (Which arguably should be reported to the user, but it should also work.)dbus-monitor, with messages not containing org.freedesktop.Secret removed
Tests
Here's my test tool:
These have a single password file opened and unlocked
Actual test cases have to go in comments because of github length restrictions 🐼
Versions and stuff
Go stuff:
Keepassxc debug output:
dbus-daemon is
1.14.6
, just in case.Generally, I'm on arch linux with a lot of stuff, including keepassxc, gh and go, pulled in via nix and home-manager
The text was updated successfully, but these errors were encountered: