Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: make refresh notebook still commit successful notebooks on fail #313

Merged
merged 2 commits into from
Oct 3, 2023
Merged

chore: make refresh notebook still commit successful notebooks on fail #313

merged 2 commits into from
Oct 3, 2023

Conversation

jfrery
Copy link
Collaborator

@jfrery jfrery commented Sep 29, 2023

@jfrery jfrery requested a review from a team as a code owner September 29, 2023 10:17
@cla-bot cla-bot bot added the cla-signed label Sep 29, 2023
@jfrery jfrery force-pushed the chore/allow_commit_refresh_notebook_with_failure branch from ff1ba98 to b2d4927 Compare September 29, 2023 10:17
@jfrery jfrery marked this pull request as draft September 29, 2023 10:27
@jfrery
Copy link
Collaborator Author

jfrery commented Sep 29, 2023 •
edited
Loading

I am refreshing the notebooks here with the new workflow and will cherry-pick the commit in #304.

Also need to revert the on: push.

@jfrery jfrery marked this pull request as ready for review October 2, 2023 17:37
@jfrery jfrery force-pushed the chore/allow_commit_refresh_notebook_with_failure branch from 2a2b3cf to 44e0e0e Compare October 3, 2023 07:10
RomanBredehoft
RomanBredehoft requested changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure these changes makes successful notebooks be committed even if another fails ? or at least I can't see what changes would make this possible here !

@jfrery
Copy link
Collaborator Author

jfrery commented Oct 3, 2023

I'm not sure these changes makes successful notebooks be committed even if another fails ? or at least I can't see what changes would make this possible here !

Yes they have been committed in #304 while Deployment notebook failed.

jfrery
jfrery commented Oct 3, 2023
View reviewed changes
script/make_utils/jupyter.sh
echo "${NOTEBOOK}" >> "${SUCCESSFUL_NOTEBOOKS}"
else
echo "${NOTEBOOK}" >> "${FAILED_NOTEBOOKS}"
fi
END=$(date +%s)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what makes the refresh notebook not crash on failure @RomanBredehoft .

RomanBredehoft
RomanBredehoft approved these changes Oct 3, 2023
View reviewed changes
Copy link
Collaborator

@RomanBredehoft RomanBredehoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find it weird that this makes it possible but I trust you ! thanks a lot for this !!

@jfrery jfrery merged commit a69b21a into main Oct 3, 2023
8 checks passed
@jfrery jfrery deleted the chore/allow_commit_refresh_notebook_with_failure branch October 3, 2023 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RomanBredehoft RomanBredehoft RomanBredehoft approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrery @RomanBredehoft