Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: integrate the new CP and the new VL #339

Closed
wants to merge 1 commit into from
Closed

chore: integrate the new CP and the new VL #339

wants to merge 1 commit into from

Conversation

bcm-at-zama
Copy link
Collaborator

  • integrate the new CP
  • check it works fine with the new VL

refs #https://github.com/zama-ai/concrete-ml-internal/issues/3841

@bcm-at-zama bcm-at-zama requested a review from a team as a code owner October 5, 2023 10:10
@cla-bot cla-bot bot added the cla-signed label Oct 5, 2023
bcm-at-zama
bcm-at-zama commented Oct 5, 2023
View reviewed changes
src/concrete/ml/common/utils.py
@@ -37,7 +37,7 @@
# Use new VL with .simulate() by default once CP's multi-parameter/precision bug is fixed
# TODO: https://github.com/zama-ai/concrete-ml-internal/issues/3856
# Indicate if the old simulation method should be used when simulating FHE executions
USE_OLD_VL = True
USE_OLD_VL = False
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a test, we'll see if we change the default (ie, does it break some tests or does it change build execution times)

@bcm-at-zama bcm-at-zama force-pushed the integrating_the_new_vl_3841 branch 2 times, most recently from 049559e to 86b5c34 Compare October 5, 2023 13:31
@bcm-at-zama bcm-at-zama force-pushed the integrating_the_new_vl_3841 branch from 86b5c34 to d40c4c5 Compare October 5, 2023 15:00
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Coverage failed ❌

Coverage details 

---------- coverage: platform linux, python 3.8.18-final-0 -----------
Name                                               Stmts   Miss  Cover   Missing
--------------------------------------------------------------------------------
src/concrete/ml/quantization/quantized_module.py     208      1    99%   489
--------------------------------------------------------------------------------
TOTAL                                               6185      1    99%

50 files skipped due to complete coverage.

@bcm-at-zama
Copy link
Collaborator Author

so looks like we have issues in pytest. Not obvious if they are due to CP or if some tests in CML need to be updated, due to the new VL: will make issues

@bcm-at-zama
Copy link
Collaborator Author

Related to https://github.com/zama-ai/concrete-ml-internal/issues/4048

@bcm-at-zama
Copy link
Collaborator Author

sorry dup of #336

@bcm-at-zama bcm-at-zama closed this Oct 6, 2023
@RomanBredehoft RomanBredehoft deleted the integrating_the_new_vl_3841 branch October 31, 2023 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bcm-at-zama