Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update packages used in tests with pypi #348

Merged
merged 1 commit into from
Oct 9, 2023

Conversation

RomanBredehoft
Copy link
Collaborator

We currently have some coverage issues with pypi tests in the weekly CI (https://github.com/zama-ai/concrete-ml/actions/runs/6450198846/job/17509408289). Not sure why it happens but let's start with updating the packages used

Besides, we should probably take another look at https://github.com/zama-ai/concrete-ml-internal/issues/2005 and more specifically https://github.com/zama-ai/concrete-ml-internal/issues/2685 in order to avoid such manual updates

refs https://github.com/zama-ai/concrete-ml-internal/issues/4030

@RomanBredehoft RomanBredehoft requested a review from a team as a code owner October 9, 2023 14:29
@cla-bot cla-bot bot added the cla-signed label Oct 9, 2023
Copy link
Collaborator

@fd0r fd0r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for now but would be great to have optional requirements so that we could do pip concrete-ml[dev]

@RomanBredehoft
Copy link
Collaborator Author

Fine for now but would be great to have optional requirements so that we could do pip concrete-ml[dev]

I agree, hence the links I referenced above !

@RomanBredehoft RomanBredehoft merged commit ab6f93c into main Oct 9, 2023
8 checks passed
@RomanBredehoft RomanBredehoft deleted the chore/update_tests_with_pypi branch October 9, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants