Add virtual_backend_kwargs argument to open_virtual_dataset #315
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #243 (comment) we need to pass a
fs_root
kwarg down to some but not all readers. We will have other reader-specific kwargs like this come up in future too. To be in keeping withxarray.open_dataset
's API these should be passed as a dict calledreader_kwargs
orbackend_kwargs
.However there is an existing
reader_options
kwarg, which is meant to be specifically forfsspec
options. Having bothreader_options
andreader_kwargs
would be confusing, so should wea) rename
reader_options
toreader_kwargs
, having it include fsspec options too,b) have
reader_kwargs
andfsspec_kwargs
, deprecatingreader_options
?So far this PR just adds a
reader_kwargs
option to all backends, but raises if it is used.cc @norlandrhagen @sharkinsspatial
docs/releases.rst
api.rst