Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All tests fail when l10n.assertAll called in one of the tests while multithreading #116

Open
dmtgrinevich opened this issue Apr 5, 2023 · 3 comments
Labels
bug Something isn't working
Milestone

Comments

@dmtgrinevich
Copy link
Contributor

No description provided.

@dmtgrinevich dmtgrinevich changed the title L10N: add multithreading support All tests fail when l10n.assertAll called in one of the tests while multithreading Apr 5, 2023
@dmtgrinevich
Copy link
Contributor Author

Bug
reproduce:

  1. add L10N.assertAll() into several test methods
  2. L10N.assertAll() should contain at least one fail assert
  3. launch test methods in multithread

@akamarouski akamarouski added this to the 1.0.4 milestone Apr 10, 2023
@akamarouski akamarouski added the bug Something isn't working label Apr 10, 2023
@akamarouski
Copy link
Contributor

@dmtgrinevich please retest with the latest carina

@dmtgrinevich
Copy link
Contributor Author

For example we got tests:

  @Test()
    public void t1() {
        ...
        L10N.assertAll();
    }

    @Test()
    public void t2() {
        ...
        L10N.assertAll();
    }

    @Test
    public void t3() {
        ...
        L10N.assertAll();
    }

Imagine we launch them in one thread. If L10N.assertAll() in t1() method generate's assertion, than this assertion will be included in all other calls of L10N.assertAll() in t2() and t3() and those tests will fail even if no new assertions were found.

While multithreading the latest completed tests will include all assertions from earlier ones

@akamarouski akamarouski modified the milestones: 1.0.4, 1.0.5 Jun 1, 2023
@akamarouski akamarouski transferred this issue from zebrunner/carina-utils Jun 27, 2023
@akamarouski akamarouski modified the milestones: 1.1.5, 1.1.x Jun 27, 2023
@akamarouski akamarouski removed this from the 1.1.x milestone Sep 7, 2023
@akamarouski akamarouski added this to the 1.3.x milestone Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Todo
Development

No branches or pull requests

2 participants