From 84791b670e5a9f1bc2c672bf204eed5e76738478 Mon Sep 17 00:00:00 2001 From: azarouski Date: Mon, 23 Jan 2023 16:57:37 +0300 Subject: [PATCH] * `treat_skips_as_failures` setting was fixed * documentation was actualised --- README.md | 2 +- examples/example.robot | 4 ++-- src/robotframework_zebrunner/api/models.py | 2 +- src/robotframework_zebrunner/listener.py | 1 + src/robotframework_zebrunner/settings.py | 1 + 5 files changed, 6 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index dcda823..6c01772 100644 --- a/README.md +++ b/README.md @@ -63,7 +63,7 @@ reporting: ms-teams-channels: automation, qa-team emails: example@example.com run: - treat_skips_as_failures: false + treat-skips-as-failures: false display-name: Nightly Regression Suite build: 1.12.1.96-SNAPSHOT environment: TEST-1 diff --git a/examples/example.robot b/examples/example.robot index ca7036b..33db0c8 100644 --- a/examples/example.robot +++ b/examples/example.robot @@ -21,12 +21,12 @@ Super long long long long long long long long long long long long long long long Open Google Chrome [Tags] ${caps} Evaluate {"enableVideo": True, "enableLogs": True, "enableVNC": True, "provider": "zebrunner"} - SeleniumLibrary.Open Browser https://google.com chrome remote_url=https://{URL}/wd/hub desired_capabilities=${caps} + SeleniumLibrary.Open Browser https://google.com chrome remote_url=http://localhost:4444/wd/hub desired_capabilities=${caps} SeleniumLibrary.Close Browser Open Firefox [Tags] ${caps} Evaluate {"enableVideo": True, "enableLogs": True, "enableVNC": True, "provider": "zebrunner"} - SeleniumLibrary.Open Browser https://google.com firefox remote_url=https://{URL}/wd/hub desired_capabilities=${caps} + SeleniumLibrary.Open Browser https://google.com firefox remote_url=http://localhost:4444/wd/hub desired_capabilities=${caps} Should Be True 2 + 2 == 5 SeleniumLibrary.Close Browser diff --git a/src/robotframework_zebrunner/api/models.py b/src/robotframework_zebrunner/api/models.py index f267448..1adfde9 100644 --- a/src/robotframework_zebrunner/api/models.py +++ b/src/robotframework_zebrunner/api/models.py @@ -66,7 +66,7 @@ class Config: class TestRunConfigModel(CamelModel): environment: Optional[str] = None build: Optional[str] = None - treat_skips_as_failures: bool = True + treat_skips_as_failures: bool class MilestoneModel(CamelModel): diff --git a/src/robotframework_zebrunner/listener.py b/src/robotframework_zebrunner/listener.py index 725876c..c5d0fa0 100644 --- a/src/robotframework_zebrunner/listener.py +++ b/src/robotframework_zebrunner/listener.py @@ -78,6 +78,7 @@ def _start_test_run(self, data: running.TestSuite) -> Optional[int]: config=TestRunConfigModel( environment=settings.run.environment, build=settings.run.build, + treat_skips_as_failures=settings.run.treat_skips_as_failures, ), ci_context=resolve_ci_context(), ) diff --git a/src/robotframework_zebrunner/settings.py b/src/robotframework_zebrunner/settings.py index 9b7ce57..b195d88 100644 --- a/src/robotframework_zebrunner/settings.py +++ b/src/robotframework_zebrunner/settings.py @@ -18,6 +18,7 @@ class TestRunSettings(BaseModel): build: Optional[str] = None environment: Optional[str] = None context: Optional[str] = None + treat_skips_as_failures: bool = True class ServerSettings(BaseModel):