Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View NPM scripts #12308

Closed
1 task done
Angelk90 opened this issue May 26, 2024 · 10 comments
Closed
1 task done

View NPM scripts #12308

Angelk90 opened this issue May 26, 2024 · 10 comments
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] javascript JavaScript programming language support language An umbrella label for all programming languages syntax behaviors tooling An umbrella label for language tools, linters, formatters, etc workspace Feedback for workspace management, layout, interactions, etc

Comments

@Angelk90
Copy link
Contributor

Check for existing issues

  • Completed

Describe the feature

Registrazione.schermo.2024-05-26.alle.10.37.52.mov

Hi! @RemcoSmitsDev : Since you've already worked on something similar, you might want to take a look.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

@Angelk90 Angelk90 added admin read Pending admin review enhancement [core label] triage Maintainer needs to classify the issue labels May 26, 2024
@RemcoSmitsDev
Copy link
Contributor

Can you explain more what you are missing inside Zed now and what problem the feature you are pointing out solves? If I look at the video, it seems that it's similar to this, but more in a file structure way.

Screenshot 2024-05-26 at 11 13 46

@Angelk90
Copy link
Contributor Author

Angelk90 commented May 26, 2024

@RemcoSmitsDev : To do what you say to execute a command I have to open search for the package.json file, open it, click to execute the command.

Instead, if it is automatically detected that there is a package.json file, give the possibility as vscode does to make a view appear, with possible commands that can be executed quickly.

Screenshot 2024-05-26 alle 14 07 58

@versecafe
Copy link
Contributor

instead of a terminal UI for it could have the tasks panel search over all package.json, Cargo.toml, etc to find all valid "scripts" ignoring dirs that are in the .gitignore

@Angelk90
Copy link
Contributor Author

@versecafe : Is there a panel tasks?

@versecafe
Copy link
Contributor

image

It also picks up default tasks for rust projects such as cargo run cargo test etc

@RemcoSmitsDev
Copy link
Contributor

Yeah, like @versecafe is pointing out. Zed already has a modal where you can see all the tasks that you can run inside the current context. If you would like to run tasks that are not connected to a context (file, line, column, symbol etc.) then you need to make them yourself. That you could see all the tasks, instead only the ones that you can run in the current context.

So to come back to your feature request, I think the task: spawn modal already shows all the tasks you want to see in a quick way.

@Angelk90
Copy link
Contributor Author

@RemcoSmitsDev : I don't see anything at the moment.
Screenshot 2024-05-26 alle 22 01 02

@RemcoSmitsDev
Copy link
Contributor

RemcoSmitsDev commented May 26, 2024

@Angelk90 Running scripts inside package.json and composer.json was just merged a couple of hours ago. This will probably be out Wednesday in the preview release.

And keep in mind that the package.json and composer.json tasks/runnable are only shown if you are in the right context. We could maybe show the tasks that do not depend on current SYMBOL, selected text, row, column always when you are in the current file Instead, only if you are in the runnable ranges, so it's more close to your initial screenshot.

Tasks like these are not connected to a specific part of your code, that is why you always see them if you are in a Rust file.
Screenshot 2024-05-26 at 22 24 45

@Moshyfawn Moshyfawn added editor Feedback for code editing, formatting, editor iterations, etc javascript JavaScript programming language support language An umbrella label for all programming languages syntax behaviors tooling An umbrella label for language tools, linters, formatters, etc workspace Feedback for workspace management, layout, interactions, etc and removed triage Maintainer needs to classify the issue labels May 26, 2024
@JosephTLyons JosephTLyons removed the admin read Pending admin review label May 28, 2024
@reslear
Copy link
Contributor

reslear commented Oct 10, 2024

It would also be cool to have automatic script loading with the ability to pins

CleanShot.2024-10-10.at.20.03.12.mp4

@notpeter
Copy link
Member

Since this issue was opened, Zed has added support for detect npm scripts. Just open package.json in question:
Screenshot 2024-12-16 at 3 01 04
And you will have a series of Play Buttons next to them.

Zed currently does not have a dedicated tasks panel and instead has opted to include task runnables in the context where they can be used, either via the Task Modal or in the sidebar.

This is design decision, partly to avoid the clutter common in a VSCode unified tasks panel:
Screenshot 2024-12-16 at 3 19 40

Thanks for reporting.

@notpeter notpeter closed this as not planned Won't fix, can't repro, duplicate, stale Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor Feedback for code editing, formatting, editor iterations, etc enhancement [core label] javascript JavaScript programming language support language An umbrella label for all programming languages syntax behaviors tooling An umbrella label for language tools, linters, formatters, etc workspace Feedback for workspace management, layout, interactions, etc
Projects
None yet
Development

No branches or pull requests

7 participants